-
Notifications
You must be signed in to change notification settings - Fork 477
Document how to use zone config extensions to remove read replicas #22371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for cockroachdb-interactivetutorials-docs canceled.
|
✅ Deploy Preview for cockroachdb-api-docs canceled.
|
ad06ca2 to
c007aea
Compare
|
@rafiss mind taking a look at this doc update? asking bc you are the author of cockroachdb/cockroach#156228 please let me know if any of what i've written is incorrect, or if i'm missing any important information - thank you! |
rafiss
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! thanks for handling this
✅ Netlify Preview
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Netlify Preview
To edit notification comments on pull requests, go to your Netlify project configuration. |
florence-crl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rmloveland please check this snippet in the context of the surrounding section. thanks.
|
|
||
| #### Override specific fields of a schema object's zone configs | ||
|
|
||
| In this example we will configure a multi-region [MovR]({% link {{ page.version.version }}/movr.md %}) database to update its [`lease_preferences`]({% link {{ page.version.version }}/configure-replication-zones.md %}#lease_preferences) field. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new num_replicas update that you added in the example should be mentioned in this intro sentence:
| In this example we will configure a multi-region [MovR]({% link {{ page.version.version }}/movr.md %}) database to update its `num_replicas` and [`lease_preferences`]({% link {{ page.version.version }}/configure-replication-zones.md %}#lease_preferences) fields. |
|
|
||
| In this example we will configure a multi-region [MovR]({% link {{ page.version.version }}/movr.md %}) database to update its [`lease_preferences`]({% link {{ page.version.version }}/configure-replication-zones.md %}#lease_preferences) field. | ||
|
|
||
| Setting the [primary region](#set-primary-region) to `us-east1` [during the setup steps](#use-zone-config-extensions) added `us-east1` to `lease_preferences`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| Setting the [primary region](#set-primary-region) to `us-east1` [during the setup steps](#use-zone-config-extensions) added `us-east1` to `lease_preferences` and set `num_replicas` to `5`. |
| | range_min_bytes = 134217728, | ||
| | range_max_bytes = 536870912, | ||
| | gc.ttlseconds = 90000, | ||
| | num_replicas = 5, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| | num_replicas = 3, |
| (1 row) | ||
| ~~~ | ||
|
|
||
| The `lease_preferences` field is now updated to include `us-west1`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| The `num_replicas` field is now updated to include `3`. The `lease_preferences` field is now updated to include `us-west1`. |
| (1 row) | ||
| ~~~ | ||
|
|
||
| In a multi-region database, the default zone configuration may include additional non-voting replicas (for example, to support [follower reads]({% link {{ page.version.version }}/follower-reads.md %})). The database's [survival goal]({% link {{ page.version.version }}/multiregion-overview.md %}#survival-goals) depends only on the number of voting replicas (`num_voters`), not the total number of replicas (`num_replicas`). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit
| In a multi-region database, the default zone configuration may include additional non-voting replicas (for example, to support [follower reads]({% link {{ page.version.version }}/follower-reads.md %})). The database's [survival goal]({% link {{ page.version.version }}/multiregion-overview.md %}#survival-goals) depends only on the number of voting replicas (`num_voters`), not the total number of replicas (`num_replicas`). | |
| In a multi-region database, the default zone configuration can include additional non-voting replicas, for example, to support [follower reads]({% link {{ page.version.version }}/follower-reads.md %}). The database's [survival goal]({% link {{ page.version.version }}/multiregion-overview.md %}#survival-goals) depends only on the number of voting replicas (`num_voters`), not on the total number of replicas (`num_replicas`). |
Fixes DOC-15023