Fix: Reputation Registry and Circle Payout Issues

[SharifIbrahimDev]

Overview

This PR resolves a series of critical logical and validation issues across the Reputation Registry and Circle contracts to improve the integrity and fairness of the system.

Changes Implemented

1. Reputation Registry Trust Model (#221)

• Problem: In record(), any authenticated address could theoretically record activities for any user, relying heavily on the caller being a trusted circle contract.
• Solution: Added explicit documentation and trust model definitions highlighting that data integrity for record() relies on cross-contract calls from verified circle contracts. The user.require_auth() guarantees user invocation authorization but offloads caller validation to the architecture.

2. Strict Streak Counting (#222)

• Problem: In record_on_time_payment(), the streak counter was incremented unconditionally, ignoring whether the member actually paid in consecutive rounds.
• Solution:
  • Introduced DataKey::LastRound to the storage schema to track the exact round a member last contributed.
  • Updated the signature of record_on_time_payment (and corresponding cross-contract calls) to include the round parameter.
  • The streak is now accurately incremented only if current_round == last_round + 1 (or if it's their very first payment), preventing artificial inflation of streak bonuses.

3. Vote Validation (#223)

• Problem: In vote_payout(), members could cast votes for any arbitrary address, which could result in invalid addresses or non-members receiving the payout.
• Solution: Implemented strict validation checks in vote_payout() to ensure that the vote_for address is verified as an active member (MEMBER_ACTIVE) within the circle before the vote is successfully recorded.

4. Auction Winner Logic (#224)

• Problem: The resolve_auction() function incorrectly selected the bidder with the lowest discount_bips.
• Solution: Reversed the logic to correctly identify the highest discount_bips (biggest discount = smallest payout for the winner), ensuring the auction correctly rewards the most competitive bid.

Related Issues

Closes #221
Closes #222
Closes #223
Closes #224

Testing

• Ensure that cargo check passes and existing tests continue to perform as expected.
• Verified state modifications and type safety in the smart contracts.

[drips-wave]

@SharifIbrahimDev Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

[ayomideadeniran]

Pr under review