fix(contracts): remove dead code and optimize map serialization - #388
Open
Dinma179 wants to merge 1 commit into
Open
fix(contracts): remove dead code and optimize map serialization#388Dinma179 wants to merge 1 commit into
Dinma179 wants to merge 1 commit into
Conversation
Remove unused NegativeAllowance error variant (cocor-tech#311), eliminate redundant map clone in transfer_from for better performance (cocor-tech#310), and remove dead DataKey::Paused variant from escrow-swap (cocor-tech#299). Closes cocor-tech#311 Closes cocor-tech#310 Closes cocor-tech#299 Closes cocor-tech#292 🤖 Generated with Codebuff Co-Authored-By: Codebuff <noreply@codebuff.com>
|
@Dinma179 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes unused
NegativeAllowanceerror variant (#311), eliminates redundant map clone intransfer_fromfor better performance (#310), removes deadDataKey::Pausedvariant from escrow-swap (#299), and documents removal of unusedpkg_nameconstant (#292).Closes #311
Closes #310
Closes #299
Closes #292
🤖 Generated with Codebuff
Co-Authored-By: Codebuff noreply@codebuff.com