feat(contacts): show one-time Flipcash contacts discovery prompt#811
Merged
Conversation
github-actions
Bot
added
type: feature
bmc08gt
force-pushed
the
feat/discover-flipcash-contacts
branch
2 times, most recently
from
ddec5b8 to
99c8669
Compare
Persist a `hasDiscoveredFlipcashContacts` flag on `ContactSyncStateEntity` (set to `true` the first time `fetchFlipcashContacts()` returns a non-empty set) and surface it as a once-ever `BottomBarManager.showInfo()` prompt in `SendFlowViewModel`. When dismissed, `consumeContactsDiscovery()` clears the flag in both the DB and in-memory state so the prompt never reappears. Also fix `clearAll()` to delete all mappings on logout (prevents stale `hasEverSynced` on re-login) and sequence the permission-revocation check before sync on foreground resume to eliminate a race. Signed-off-by: Brandon McAnsh <git@bmcreations.dev>
bmc08gt
changed the title
bmc08gt
force-pushed
the
feat/discover-flipcash-contacts
branch
from
99c8669 to
6b3d3fa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hasDiscoveredFlipcashContactsonContactSyncStateEntity— set totrueon first non-emptyfetchFlipcashContacts()resultBottomBarManager.showInfo()prompt inSendFlowViewModelwith pluralized contact countconsumeContactsDiscovery()clears the flag in both the DB and in-memory state so the prompt never reappearsclearAll()to delete all mappings on logout (prevents stalehasEverSyncedon re-login)