Skip to content

Add global lock on key reservation in nonce worker #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeffyanta merged 1 commit into from
Dec 10, 2025
Merged

Add global lock on key reservation in nonce worker #26

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion ocp/worker/nonce/keys.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ package nonce
import (
"context"
"fmt"
"sync"
"time"

"go.uber.org/zap"
Expand All @@ -13,6 +14,10 @@ import (
"github.com/code-payments/ocp-server/retry"
)

var (
globalKeyLock sync.Mutex
)

func (p *runtime) generateKey(ctx context.Context) (*vault.Record, error) {
// todo: audit whether we should be creating keys on the same server.
// Perhaps this should be done outside this box.
Expand Down Expand Up @@ -83,7 +88,8 @@ func (p *runtime) generateKeys(runtimeCtx context.Context) error {
}

func (p *runtime) reserveExistingKey(ctx context.Context) (*vault.Record, error) {
// todo: add distributed locking here.
globalKeyLock.Lock()
defer globalKeyLock.Unlock()

keys, err := p.data.GetAllKeysByState(ctx, vault.StateAvailable,
query.WithLimit(1),
Expand Down
Loading