Skip to content

Remove Code from user-agent parsing #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeffyanta merged 1 commit into from
Dec 12, 2025
Merged

Remove Code from user-agent parsing #27

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion grpc/client/user_agent.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ const (
)

var (
userAgentPattern = fmt.Sprintf("(Code|OpenCodeProtocol)/(iOS|Android)/%s", versionPattern)
userAgentPattern = fmt.Sprintf("OpenCodeProtocol/(iOS|Android)/%s", versionPattern)
userAgentRegex = regexp.MustCompile(userAgentPattern)
)

Expand Down
18 changes: 9 additions & 9 deletions grpc/client/user_agent_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,10 @@ import (

func TestGetUserAgent_HappyPath(t *testing.T) {
for _, headerValue := range []string{
"Code/iOS/11.22.33",
"Code/Android/11.22.33",
"OpenCodeProtocol/iOS/11.22.33",
"OpenCodeProtocol/Android/11.22.33",
"Mozilla/5.0 Code/iOS/11.22.33 Mobile Safari/533.1",
"OpenCodeProtocol/Android/11.22.33",
"Mozilla/5.0 OpenCodeProtocol/iOS/11.22.33 Mobile Safari/533.1",
} {
ctx := context.Background()
ctx, err := headers.ContextWithHeaders(ctx)
Expand Down Expand Up @@ -44,14 +44,14 @@ func TestGetUserAgent_ParseError(t *testing.T) {
"Mozilla/5.0 Mobile Safari/533.1",

// Unsupported device type
"Code/Windows/1.2.3",
"OpenCodeProtocol/Windows/1.2.3",

// Version components missing
"Code/iOS/.2.3",
"Code/iOS/..3",
"Code/iOS/..",
"Code/iOS/",
"Code/iOS",
"OpenCodeProtocol/iOS/.2.3",
"OpenCodeProtocol/iOS/..3",
"OpenCodeProtocol/iOS/..",
"OpenCodeProtocol/iOS/",
"OpenCodeProtocol/iOS",
} {
ctx := context.Background()
ctx, err := headers.ContextWithHeaders(ctx)
Expand Down
Loading