Skip to content

Improve GetHistoricalMintData error handling for exchange rate or reserve not found errors #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeffyanta merged 1 commit into from
Jan 19, 2026
Merged

Improve GetHistoricalMintData error handling for exchange rate or reserve not found errors #60

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions ocp/rpc/currency/server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,11 @@ func (s *currencyServer) GetHistoricalMintData(ctx context.Context, req *currenc
endTime,
interval,
)
if err != nil {
if err == currency.ErrNotFound {
return &currencypb.GetHistoricalMintDataResponse{
Result: currencypb.GetHistoricalMintDataResponse_MISSING_DATA,
}, nil
} else if err != nil {
log.With(zap.Error(err)).Warn("failed to load currency reserve history")
return nil, status.Error(codes.Internal, "")
}
Expand All @@ -275,7 +279,11 @@ func (s *currencyServer) GetHistoricalMintData(ctx context.Context, req *currenc
endTime,
interval,
)
if err != nil {
if err == currency.ErrNotFound {
return &currencypb.GetHistoricalMintDataResponse{
Result: currencypb.GetHistoricalMintDataResponse_MISSING_DATA,
}, nil
} else if err != nil {
log.With(zap.Error(err)).Warn("failed to load exchange rate history")
return nil, status.Error(codes.Internal, "")
}
Expand Down
Loading