Skip to content

Fix swap external deposit exchange rate #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeffyanta merged 1 commit into from
Jan 26, 2026
Merged

Fix swap external deposit exchange rate #74

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions ocp/worker/swap/util.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,6 @@ func (p *runtime) updateBalancesForFinalizedSwap(ctx context.Context, swapRecord
}

var exchangeCurrency currency_lib.Code
var exchangeRate float64
var nativeAmountWithoutFees float64
var usdMarketValueWithoutFees float64
switch swapRecord.FundingSource {
Expand All @@ -187,7 +186,6 @@ func (p *runtime) updateBalancesForFinalizedSwap(ctx context.Context, swapRecord
}

exchangeCurrency = fundingIntentRecord.SendPublicPaymentMetadata.ExchangeCurrency
exchangeRate = fundingIntentRecord.SendPublicPaymentMetadata.ExchangeRate
nativeAmountWithoutFees = fundingIntentRecord.SendPublicPaymentMetadata.NativeAmount
usdMarketValueWithoutFees = fundingIntentRecord.SendPublicPaymentMetadata.UsdMarketValue
case swap.FundingSourceExternalWallet:
Expand All @@ -205,7 +203,6 @@ func (p *runtime) updateBalancesForFinalizedSwap(ctx context.Context, swapRecord
return 0, err
}
nativeAmountWithoutFees = usdMarketValueWithoutFees
exchangeRate = currency_util.CalculateExchangeRate(common.CoreMintAccount, swapRecord.Amount, usdMarketValueWithoutFees)
default:
return 0, errors.New("unsupported funding source")
}
Expand All @@ -223,6 +220,8 @@ func (p *runtime) updateBalancesForFinalizedSwap(ctx context.Context, swapRecord
).Float64()
}

exchangeRate := currency_util.CalculateExchangeRate(toMint, uint64(deltaQuarksIntoOmnibus), nativeAmount)

err = p.data.ExecuteInTx(ctx, sql.LevelDefault, func(ctx context.Context) error {
// For transaction history
intentRecord := &intent.Record{
Expand Down