-
Notifications
You must be signed in to change notification settings - Fork 15
refactor(plugin-coverage,plugin-js-packages): use runner function instead of runner config #1186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
View your CI Pipeline Execution ↗ for commit 6c0635b
☁️ Nx Cloud last updated this comment at |
|
View your CI Pipeline Execution ↗ for commit 0d7e45d
☁️ Nx Cloud last updated this comment at |
@code-pushup/ci
@code-pushup/cli
@code-pushup/core
@code-pushup/create-cli
@code-pushup/models
@code-pushup/axe-plugin
@code-pushup/nx-plugin
@code-pushup/coverage-plugin
@code-pushup/eslint-plugin
@code-pushup/js-packages-plugin
@code-pushup/jsdocs-plugin
@code-pushup/lighthouse-plugin
@code-pushup/typescript-plugin
@code-pushup/utils
commit: |
0d7e45d to
6c0635b
Compare
Code PushUp🤨 Code PushUp report has both improvements and regressions – compared current commit 75e4438 with previous commit 7b82402. 🕵️ See full comparison in Code PushUp portal 🔍 🏷️ Categories👍 5 groups improved, 👎 5 groups regressed, 👍 13 audits improved, 👎 6 audits regressed, 40 audits changed without impacting score🗃️ Groups
24 other groups are unchanged. 🛡️ Audits
620 other audits are unchanged. |
Code PushUp🤨 Code PushUp report has both improvements and regressions – compared current commit 75e4438 with previous commit 7b82402. 💼 Project
|
| 🏷️ Category | ⭐ Previous score | ⭐ Current score | 🔄 Score change |
|---|---|---|---|
| Code coverage | 🟡 86 | 🟡 87 | |
| Documentation | 🟡 64 | 🟡 64 |
4 other categories are unchanged.
👍 2 groups improved, 👍 4 audits improved, 1 audit changed without impacting score
🗃️ Groups
| 🔌 Plugin | 🗃️ Group | ⭐ Previous score | ⭐ Current score | 🔄 Score change |
|---|---|---|---|---|
| Code coverage | Code coverage metrics | 🟡 86 | 🟡 87 | |
| JSDoc coverage | Documentation coverage | 🟡 64 | 🟡 64 |
13 other groups are unchanged.
🛡️ Audits
| 🔌 Plugin | 🛡️ Audit | 📏 Previous value | 📏 Current value | 🔄 Value change |
|---|---|---|---|---|
| Code coverage | Branch coverage | 🟩 90.6 % | 🟩 93.1 % | |
| Code coverage | Function coverage | 🟨 82.7 % | 🟨 84.3 % | |
| Code coverage | Line coverage | 🟨 87.8 % | 🟨 88.3 % | |
| JSDoc coverage | Functions coverage | 🟥 43 undocumented functions | 🟥 42 undocumented functions | |
| JSDoc coverage | Variables coverage | 🟥 29 undocumented variables | 🟥 28 undocumented variables |
439 other audits are unchanged.
💼 Project plugin-coverage
🤨 Code PushUp report has both improvements and regressions.
🕵️ See full comparison in Code PushUp portal 🔍
| 🏷️ Category | ⭐ Previous score | ⭐ Current score | 🔄 Score change |
|---|---|---|---|
| Documentation | 🟡 71 | 🟡 71 | |
| Code coverage | 🟡 88 | 🟡 88 |
4 other categories are unchanged.
👍 1 group improved, 👎 1 group regressed, 👍 3 audits improved, 👎 1 audit regressed, 1 audit changed without impacting score
🗃️ Groups
| 🔌 Plugin | 🗃️ Group | ⭐ Previous score | ⭐ Current score | 🔄 Score change |
|---|---|---|---|---|
| JSDoc coverage | Documentation coverage | 🟡 71 | 🟡 71 | |
| Code coverage | Code coverage metrics | 🟡 88 | 🟡 88 |
13 other groups are unchanged.
🛡️ Audits
| 🔌 Plugin | 🛡️ Audit | 📏 Previous value | 📏 Current value | 🔄 Value change |
|---|---|---|---|---|
| JSDoc coverage | Functions coverage | 🟥 16 undocumented functions | 🟥 15 undocumented functions | |
| Code coverage | Branch coverage | 🟨 88.1 % | 🟨 88.9 % | |
| Code coverage | Function coverage | 🟨 88.5 % | 🟨 88 % | |
| Code coverage | Line coverage | 🟨 89.2 % | 🟨 89.4 % | |
| JSDoc coverage | Variables coverage | 🟥 10 undocumented variables | 🟥 9 undocumented variables |
439 other audits are unchanged.
12 other projects are unchanged.
Part of #888 - prerequisite for having nice logs from Code Coverage and JS Packages plugins.
Simplifies runner execution by switching to a runner function, so there's no need for an additional entry point.
In a follow-up PR, I will move logic out of
index.tsfiles, as suggested here.