-
Notifications
You must be signed in to change notification settings - Fork 15
refactor(plugin-coverage,plugin-eslint,plugin-js-packages): avoid implementation in index.ts files #1187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
View your CI Pipeline Execution ↗ for commit 0854d39
☁️ Nx Cloud last updated this comment at |
@code-pushup/ci
@code-pushup/cli
@code-pushup/core
@code-pushup/create-cli
@code-pushup/models
@code-pushup/nx-plugin
@code-pushup/axe-plugin
@code-pushup/coverage-plugin
@code-pushup/eslint-plugin
@code-pushup/js-packages-plugin
@code-pushup/jsdocs-plugin
@code-pushup/lighthouse-plugin
@code-pushup/typescript-plugin
@code-pushup/utils
commit: |
7b0fa32 to
0854d39
Compare
Code PushUp🤨 Code PushUp report has both improvements and regressions – compared current commit 4e0f6ae with previous commit 11deecf. 🕵️ See full comparison in Code PushUp portal 🔍 🏷️ Categories👍 1 group improved, 👍 6 audits improved, 11 audits changed without impacting score🗃️ Groups
33 other groups are unchanged. 🛡️ Audits662 other audits are unchanged. |
Code PushUp🥳 Code PushUp report has improved – compared current commit 4e0f6ae with previous commit 11deecf. 💼 Project
|
| 🏷️ Category | ⭐ Previous score | ⭐ Current score | 🔄 Score change |
|---|---|---|---|
| Code coverage | 🟢 99 | 🟢 99 |
5 other categories are unchanged.
👍 1 group improved, 👍 1 audit improved
🗃️ Groups
| 🔌 Plugin | 🗃️ Group | ⭐ Previous score | ⭐ Current score | 🔄 Score change |
|---|---|---|---|---|
| Code coverage | Code coverage metrics | 🟢 99 | 🟢 99 |
14 other groups are unchanged.
🛡️ Audits
| 🔌 Plugin | 🛡️ Audit | 📏 Previous value | 📏 Current value | 🔄 Value change |
|---|---|---|---|---|
| Code coverage | Branch coverage | 🟩 96 % | 🟩 96.1 % |
443 other audits are unchanged.
13 other projects are unchanged.
BioPhoton
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! This helps to manage the test coverage better!
Addresses @BioPhoton's suggestion (related to #1168):