Skip to content

Conversation

@matejchalk
Copy link
Collaborator

@matejchalk matejchalk commented Dec 15, 2025

Addresses @BioPhoton's suggestion (related to #1168):

Let's avoid having logic in ìndex.ts files. This helps us to exclude all ìndex.ts files from code coverage.

@nx-cloud
Copy link

nx-cloud bot commented Dec 15, 2025

View your CI Pipeline Execution ↗ for commit 0854d39

Command Status Duration Result
nx run ci:code-pushup -- merge-diffs --files=/h... ✅ Succeeded 5s View ↗
nx run-many --targets=code-pushup --parallel=fa... ✅ Succeeded 1m 24s View ↗
nx run-many --targets=code-pushup --parallel=fa... ✅ Succeeded 12m 20s View ↗
nx run-many -t unit-test,int-test ✅ Succeeded 1m 48s View ↗

☁️ Nx Cloud last updated this comment at 2025-12-15 14:11:26 UTC

@pkg-pr-new
Copy link

pkg-pr-new bot commented Dec 15, 2025

Open in StackBlitz

@code-pushup/ci

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/ci@1187

@code-pushup/cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/cli@1187

@code-pushup/core

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/core@1187

@code-pushup/create-cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/create-cli@1187

@code-pushup/models

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/models@1187

@code-pushup/nx-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/nx-plugin@1187

@code-pushup/axe-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/axe-plugin@1187

@code-pushup/coverage-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/coverage-plugin@1187

@code-pushup/eslint-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/eslint-plugin@1187

@code-pushup/js-packages-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/js-packages-plugin@1187

@code-pushup/jsdocs-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/jsdocs-plugin@1187

@code-pushup/lighthouse-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/lighthouse-plugin@1187

@code-pushup/typescript-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/typescript-plugin@1187

@code-pushup/utils

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/utils@1187

commit: 0854d39

@matejchalk matejchalk marked this pull request as ready for review December 15, 2025 14:00
@github-actions
Copy link
Contributor

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared current commit 4e0f6ae with previous commit 11deecf.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Performance 🔴 38 🔴 47 ↑ +9.3
Axe Accessibility 🟡 88 🟡 88 ↓ −0.1
Bug prevention 🟡 67 🟡 67
Code style 🟢 99 🟢 99
Code coverage 🟡 89 🟡 89
Security 🔴 43 🔴 43
Updates 🟡 71 🟡 71
Type Safety 🟡 56 🟡 56
Miscellaneous 🟡 67 🟡 67
Documentation 🔴 35 🔴 35
Accessibility 🟢 92 🟢 92
Best Practices 🟢 100 🟢 100
SEO 🟢 92 🟢 92
👍 1 group improved, 👍 6 audits improved, 11 audits changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Lighthouse Performance 🔴 38 🔴 47 ↑ +9.3

33 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Lighthouse Initial server response time was short 🟥 Root document took 610 ms 🟩 Root document took 560 ms ↓ −7.2 %
Lighthouse Total Blocking Time 🟥 1,270 ms 🟥 710 ms ↓ −44.3 %
Lighthouse Speed Index 🟥 6.9 s 🟨 5.8 s ↓ −16.2 %
Lighthouse Max Potential First Input Delay 🟥 1,130 ms 🟥 510 ms ↓ −55.3 %
Lighthouse First Contentful Paint 🟥 3.2 s 🟥 3.1 s ↓ −4.5 %
Lighthouse Time to Interactive 🟥 12.6 s 🟥 11.9 s ↓ −5.4 %
Lighthouse Minimizes main-thread work 🟥 8.7 s 🟥 5.9 s ↓ −31.9 %
Lighthouse JavaScript execution time 🟥 4.0 s 🟥 2.3 s ↓ −43.5 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 2,056 KiB 🟩 Total size was 2,055 KiB ↓ −0.1 %
Lighthouse Largest Contentful Paint 🟥 11.7 s 🟥 10.8 s ↓ −7.2 %
Lighthouse Metrics 🟩 100% 🟩 100% ↓ −5.4 %
Lighthouse Server Backend Latencies 🟩 1,180 ms 🟩 1,800 ms ↑ +52.7 %
Lighthouse Uses efficient cache policy on static assets 🟨 30 resources found 🟨 30 resources found ↓ −0.1 %
Lighthouse Network Round Trip Times 🟩 50 ms 🟩 10 ms ↓ −87.2 %
Lighthouse Reduce unused JavaScript 🟥 Potential savings of 187 KiB 🟥 Potential savings of 188 KiB ↓ −3.1 %
Lighthouse Reduce unused CSS 🟥 Potential savings of 94 KiB 🟥 Potential savings of 94 KiB ↓ −4.2 %
Lighthouse Remove duplicate modules in JavaScript bundles 🟥 Potential savings of 104 KiB 🟥 Potential savings of 104 KiB ↓ −3.1 %

662 other audits are unchanged.

@github-actions
Copy link
Contributor

Code PushUp

🥳 Code PushUp report has improved – compared current commit 4e0f6ae with previous commit 11deecf.

💼 Project plugin-lighthouse

🥳 Code PushUp report has improved.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Code coverage 🟢 99 🟢 99 ↑ +0.1

5 other categories are unchanged.

👍 1 group improved, 👍 1 audit improved

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Code coverage Code coverage metrics 🟢 99 🟢 99 ↑ +0.1

14 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Code coverage Branch coverage 🟩 96 % 🟩 96.1 % ↑ +0.1 %

443 other audits are unchanged.


13 other projects are unchanged.

Copy link
Collaborator

@BioPhoton BioPhoton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! This helps to manage the test coverage better!

@matejchalk matejchalk merged commit d1e8192 into main Dec 15, 2025
25 checks passed
@matejchalk matejchalk deleted the refactor-index-files branch December 15, 2025 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🧩 coverage-plugin 🧩 eslint-plugin 🧩 js-packages-plugin Plugin for audit and outdated dependencies 🔬 testing writing tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants