Allow naming agents from the UI (add displayName + rename API)#26
Open
NitayRabi wants to merge 1 commit into
Open
Allow naming agents from the UI (add displayName + rename API)#26NitayRabi wants to merge 1 commit into
NitayRabi wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
displayNameto the shared protocolagentSchemaand propagated it through the server model and responses.displayNamein the DB with migrationapps/server/drizzle/0001_agent_display_name.sqland wired it intoapps/server/src/db/schema.ts.renameAgent(agentId, displayName)and ensuredlistTopology()/findAgent()returndisplayName.PATCH /api/agents/:idinapps/server/src/app.tsthat validates and normalizes input and broadcasts topology updates.renameAgent(...)in the browser API client (apps/web/src/api.ts) and updatedAgentPickerUI (apps/web/src/components/AgentPicker.tsx) to showdisplayName ?? nameand allow inline renaming via double-click.renames an agent display name from browser API.Testing
cd apps/server && pnpm test -- --run test/app.test.tsand observed all tests passing (21 passed).cd apps/web && pnpm test -- --run test/app.test.tsxand observed all tests passing (7 passed).Codex Task