[codex] Fix fnm agent path detection#43
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
This updates agent detection so saved agent environments prepend the resolved executable directories for both the detected agent CLI and
node, then retain the original shellPATHas fallback.It also adds a regression test for an
fnm-style symlinked shim layout and documents the failure mode in the local development and past failures docs.Why
Daemon-side health probes were failing in
fnmenvironments with/usr/bin/env: 'node': No such file or directoryeven though detection succeeded interactively.The root cause was that detection persisted the shell's raw
PATHordering. Infnmsetups that can prioritize transient multishell shim directories ahead of the stable Node installation path, so later daemon runs could reuse a stale shim path.Impact
Nodes detected from
fnm-managed shells now save a more durable runtime path for agent CLIs that depend onnode, which should stop false-offline health probe failures after the daemon restarts.Existing nodes should be re-detected once so their saved agent config picks up the new PATH ordering.
Validation
go test ./internal/app ./internal/acpx ./internal/nodeconfig