refactor(web): extract shared design system tokens#72
Closed
code-yeongyu wants to merge 3 commits into
Closed
Conversation
Contributor
|
Thanks for the PR! Changes to LazyCodex land through oh-my-openagent — could you open this against omo-codex over there instead? PRs in this repository can't be merged. If you're working with a coding agent, prompt it like this:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR supersedes the stale closed draft PR #70 with a fresh branch from
origin/main(4a15494). It extracts the existing web design tokens and shared CSS layers into a dedicated design-system stylesheet while preserving the current rendered UI, behavior, and experience pixel-for-pixel.Changes
@theme, base CSS variables, global base layer, and shared.card-gradient-*utilities frompackages/web/app/globals.cssintopackages/web/app/styles/design-system.css.globals.cssas the import hub for Tailwind, shared design-system CSS, and page-specific composition CSS.packages/web/DESIGN.mdso implementation sources, live green token values, and reusable component families match the current rendered design.content/docs/skills.mdcopy; the same assertion failed on cleanorigin/mainbefore this branch..omo/ulw-loop/evidence/design-system-fidelity-v2/.Verification
Automated gates run locally in
packages/web:pnpm install --frozen-lockfilepassed.pnpm run lintpassed.pnpm run type-checkpassed.pnpm run buildpassed.pnpm run test:e2epassed: 52/52 tests.Manual/visual QA evidence:
.omo/scripts/design-system-fidelity/capture-and-drive.mjs.omo/evidence/design-system-fidelity-v2.md.omo/ulw-loop/evidence/design-system-fidelity-v2/capture-report.json.omo/ulw-loop/evidence/design-system-fidelity-v2/diffs/summary.json/and/docsacross390x844,768x1024, and1280x800.diffPixels: 0,diffRatio: 0,similarityScore: 100,dimensionsMatch: true,alphaChannelIntact: true.Notes
No visual redesign was introduced. The intent is design-system extraction and documentation fidelity with current behavior and current pixels preserved.
Summary by cubic
Extracted shared design tokens and CSS utilities into a dedicated
packages/web/app/styles/design-system.csswith no visual or behavioral changes. Also refreshed docs/tests and added a Playwright capture script with committed visual evidence.@theme, root CSS tokens, base layer, and.card-gradient-*utilities fromapp/globals.csstoapp/styles/design-system.css; keptglobals.cssas the import hub.packages/web/DESIGN.mdto match live token values and component families..omo/ulw-loop/evidence/design-system-fidelity-v2/, and refreshed one docs e2e assertion to match current copy.Written for commit 292420d. Summary will update on new commits.