added throttling for register method to prevent batch e-mail checks +…#154
Merged
idormenco merged 6 commits intocode4romania:developfrom Oct 28, 2021
Merged
Conversation
… return http error status code on already existing e-mail
Alexei000
requested review from
Puiu,
aniri,
decembrya and
idormenco
as code owners
idormenco
requested changes
Oct 19, 2021
idormenco
reviewed
Oct 20, 2021
| </ItemGroup> | ||
|
|
||
| <ItemGroup> | ||
| <Folder Include="Models\DTOs\Responses\" /> |
Member
There was a problem hiding this comment.
delete folder Models\DTOs\Responses
| private static Assembly[] GetAssemblies() => new[] | ||
| { | ||
| Assembly.GetAssembly(typeof(Startup)), | ||
| { |
Member
There was a problem hiding this comment.
can you please keep original formating for this method
Contributor
Author
There was a problem hiding this comment.
sorry, I think Resharper tried to be smart. I have reverted the change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… return http error status code on already existing e-mail
What does it fix?
Closes #61
This tries to allow the API to inform the client(s) that an e-mail is already used, but prevent a malicious actor from checking many e-mail addresses. This is done by using IP rate-limiting via AspNetCoreRateLimit library.
However, I am not sure about returning a Conflict response for existing e-mails. The alternative would be returning OK, but this requires a breaking change for the response payload model since now it is just a string.
How has it been tested?
Currently, I have performed only some manual checks and it works as expected.