TKW: add actionlint, pin deps exactly, and finish the Gale migration - #94
Merged
Merged
Conversation
- rename `.stylelintrc.json` to `gale.json`; Gale was reading it, so deleting it would have silently disabled every SCSS rule - inline the resolved `stylelint-config-recommended-scss` ruleset so no `stylelint` package is installed, directly or as a peer - drop `stylelint` and `stylelint-config-recommended-scss` from `devDependencies` - point `lint-staged` at `gale --fix` instead of `stylelint --fix` - rename `lint:css` to `lint:scss` and update both workflows - `gale --print-config` is byte-identical to the pre-change effective config - Gale implements `scss/*` natively and honors `stylelint-disable` comments, so the three existing ones still work - refresh `docs/tooling-rule-mapping.md`, `component-scaffold` and `style-critic` for the new tool names
- add `github-actionlint` (`1.7.12`), which runs the official `rhysd/actionlint` release binary - add a `lint:actions` script and fold it into `lint`, so `system-check` covers it alongside `spellcheck` - add a `Lint Actions` step to `pull-request-checks.yml` and `sanity-check.yml` - set `exact = true` under `[install]` in `bunfig.toml` so `bun add` can never write a `^` or `~` range - `@ocular-d/typos-bin` and the `spellcheck` script were already in place and already wired into both workflows
✅ Deploy Preview for theknownworld ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
actionlintand run it inlint,system-check, and both workflowsexact = trueinbunfig.tomlstylelintis installed any moreactionlint
github-actionlint(1.7.12) downloads and runs the officialrhysd/actionlintrelease binarylint:actionsscript, folded intolint, sosystem-checkcovers itLint Actionsstep inpull-request-checks.ymlandsanity-check.ymlruns-onlabel was used to confirm it actually failsExact pins
exact = trueunder[install]inbunfig.toml—bun addcan no longer write a^or~rangepackage.jsonwas already exact; nothing needed rewritingSpellcheck
@ocular-d/typos-binand thespellcheckscript were already present and already wired into both workflows — no change neededGale / stylelint removal
.stylelintrc.jsontogale.json; Gale was reading it, so deleting it outright would have silently disabled every SCSS rulestylelint-config-recommended-scssruleset, dropping bothstylelintandstylelint-config-recommended-scss(the config package pulledstylelintback in as a peer)gale --print-configis byte-identical to the pre-change effective configscss/*rules natively and honorsstylelint-disablecomments, so the three existing ones still worklint-stagedatgale --fixlint:csstolint:scss, fixing the workflow steps that still called the old namedocs/tooling-rule-mapping.md,component-scaffold, andstyle-critic