TKW: fix scripts broken by bun 1.4.2 - #95
Open
codebend3r wants to merge 1 commit into
Open
codebend3r wants to merge 1 commit into
codebend3r wants to merge 1 commit into
Conversation
- `--parallel` now takes an optional value, so `bun test --parallel --dots` swallowed `--dots` as that value — disabling parallel mode and the `--isolate` it implies. Without isolation the per-file `mock.restore()` in the `next/navigation` suites leaks across files and `bun test` spins forever. `--parallel` moved last in `test`, `test:watch`, and `coverage`. - Nested `bun run --sequential a b c` no longer parses the trailing script names and passes them as arguments to the first script, so `bun run system-check` ran `rm -rf .next typecheck lint spellcheck test build` and deleted `test/`. `lint` and `system-check` now chain with `&&`.
✅ Deploy Preview for theknownworld ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgraded the local bun toolchain from 1.3.13 to 1.4.2 (
packageManagerand@types/bunwere already pinned at1.4.2), wipednode_modules, and reinstalled. Two scripts broke under the new bun and are fixed here.bun testhung forever--parallelnow takes an optional value, sobun test --parallel --dotsswallowed--dotsas that value.--isolateit implies.mock.restore()in thenext/navigationsuites leaks into the next file —SearchComboboxthen throwsExport named 'useRouter' not found, and the runner spins at 100% CPU indefinitely.--parallelis now last intest,test:watch, andcoverage.bun run --sequentialran only the first scriptbun run --sequential a b cno longer parses the trailing script names — it passes them as arguments to the first one.bun run system-checktherefore executedrm -rf .next typecheck lint spellcheck test buildand deletedtest/.lintandsystem-checknow chain with&&, which is sequential by definition and fails fast.Verification
bun run system-checkpasses end to end — clean, typecheck, lint (ts/scss/actions), spellcheck, 921 tests across 84 files, build.