ci(contracts): add cargo fmt --check job - #265
Open
thefifthdev wants to merge 1 commit into
Open
Conversation
Add a dedicated `fmt` job to the contracts CI workflow that runs `cargo fmt --all -- --check` across the Soroban Rust workspace. The job installs only the rustfmt component (no wasm target, no caching) so it completes quickly and fails any PR containing unformatted Rust code. Also runs `cargo fmt --all` over the existing contracts to clean the baseline so the check passes on merge. Closes codebestia#136
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a dedicated
fmtjob to.github/workflows/contracts-ci.ymlthat runscargo fmt --all -- --checkacross all packages in the Soroban Rust workspace.rustfmtcomponent — nowasm32target and no caching — so it runs in well under 30 seconds.cargo fmt --allover the existing contracts to clean the baseline (proposalspackage) so the check passes on merge.Acceptance criteria
fmtjobfmtjob completes in under 30 seconds (rustfmt-only toolchain, no build)Closes #136