Claude/ci cd glossary docs 5qhb7p - #596
Merged
codebestia merged 4 commits intoAug 30, 2026
Merged
Conversation
|
@vickydve Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This was referenced Aug 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds four documentation pages closing the outstanding docs issues:
docs/ci-cd.md— reference for all nine GitHub Actions workflows (backend-ci,frontend-ci,contracts-ci,ai-agent-ci,security-ci,loadtest-nightly,pr,guard-main-branch,close-linked-issues): trigger/path-filters, jobs, and the failure signal to act on for each. Covers whyapps/web/**changes don't run backend CI,guard-main-branchas the dev-only branch enforcement mechanism,contracts-ci's 100 KB WASM size gate and PR size-report comment,loadtest-nightly's baseline-regression check and wherescripts/loadtest/baseline.jsoncomes from (a static, manually-updated file), and therust-toolchain.tomlchannel = "stable"toolchain-pinning caveat.docs/glossary.md— glossary of messaging/E2EE terms (envelope, prekey, ratchet, safety number, epoch, sealed box, fan-out), Stellar/Soroban terms (ledger, XDR, SAC, passphrase, Freighter), and project-specific coinages (device set mismatch, sibling device, resume cursor, group control event), each pointing at the implementing module. Disambiguatesciphertext(message body column) vs. envelopeciphertext,deviceIdvs.senderDeviceId, andepoch(MLS) vs.sequence(group control log).docs/development-setup.md— start-to-finish local setup guide: prerequisites with actual pinned versions (Node 20, pnpm 10.28.1, Rust stable +wasm32-unknown-unknown, Python 3.12 viauv, Docker), the fourinfra/docker-compose.ymlservices (postgres,redis,minio,minio-init), the exact clone-to-running-app command sequence, which parts run without Docker (tests mock Redis/Postgres/S3), andscripts/start-web.shplusMakefiletargets. Flags a Node 18 vs. 20 inconsistency found across workflows.apps/web/docs/components-messaging.md— reference forMessageThread,InboundMessageRow,EncryptedThumbnail, andUnavailableMessagePlaceholder, with props, render locations, the message-row states (decrypted / pre-link / undecryptable / verification-failed / file-image),EncryptedThumbnail's decrypt-to-object-URL flow and its cleanup/revoke obligation, and howprocessEnvelope.tsdistinguishes "no envelope for this device" (pre-link) from "envelope exists but decrypt failed."Notes
apps/web/docs/components-messaging.mdflags that the live conversation page currently hardcodesreason="undecryptable"instead of threading through the real unavailable reason, and that no "deleted tombstone" or "system event" message state currently exists in the messaging components — documented as-is rather than invented.Closes #543
Closes #549
Closes #541
Closes #569