Skip to content

Add conflict resolution, PR comments, and CI to storm continue#35

Merged
casperpanduro merged 3 commits intomainfrom
feature/continue-conflicts-and-comments
Mar 16, 2026
Merged

Add conflict resolution, PR comments, and CI to storm continue#35
casperpanduro merged 3 commits intomainfrom
feature/continue-conflicts-and-comments

Conversation

@casperpanduro
Copy link
Copy Markdown
Contributor

Summary

  • Conflict resolution: storm continue now merges the base branch after checkout. If there are conflicts, they're surfaced to the agent via a {{ conflicts }} template placeholder so it can resolve them.
  • PR comments: Regular PR conversation comments (not just inline review comments) are now fetched and included via {{ pr.comments }}, so feedback left as normal comments is visible to the agent.
  • CI workflow: Added .github/workflows/ci.yml to run typecheck and tests on PRs targeting main.

Test plan

  • bun test — all 52 tests pass (3 new tests for processContinue)
  • storm continue <pr-number> --dry-run on a PR with comments — verify comments appear in prompt
  • Test on a PR with base branch divergence — verify conflicts are detected and included in prompt
  • Test on a PR with no conflicts — verify clean merge and normal flow

🤖 Generated with Claude Code

casperpanduro and others added 3 commits March 16, 2026 17:32
- Add mergeBaseBranch() to detect and surface merge conflicts to the agent
- Add fetchPRCommentsAndSessionId() to fetch regular PR comments (not just inline review comments)
- Add {{ conflicts }} and {{ pr.comments }} template placeholders
- Update default continue template with conflict resolution instructions
- Add CI workflow to run typecheck and tests on PRs
- Add processContinue tests for merge and conflict detection

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
bun's mock.module leaks across test files when run in the same
process, causing false failures. Run each file separately.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
`bun test` runs all files in one process; `bun run test` uses the
package.json script that runs each file separately.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@casperpanduro casperpanduro merged commit 787f055 into main Mar 16, 2026
1 check passed
@casperpanduro casperpanduro deleted the feature/continue-conflicts-and-comments branch March 16, 2026 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant