Skip to content

fix: Shell escaping in release notes [patch] - #3

Merged
obarlik merged 5 commits into
masterfrom
dev
Aug 20, 2025
Merged

obarlik merged 5 commits into
masterfrom
dev

Conversation

@obarlik

@obarlik obarlik commented Aug 20, 2025

Copy link
Copy Markdown
Member

πŸ› Critical Bug Fix

This PR fixes the shell escaping issue in automated release workflow that was causing releases to fail.

πŸ”§ Issue Fixed:

  • Release notes generation was failing due to shell variable expansion conflicts
  • PR body content with bullet points (- feat:, - feature:) was being interpreted as shell commands
  • Error: 'feat:: command not found', 'dev: command not found'

βœ… Solution:

  • Direct GitHub expression interpolation in heredoc EOF block
  • Eliminates shell variable expansion conflicts
  • Safe handling of all PR content including special characters

🎯 Test:

This PR uses [patch] manual override to test the fixed workflow and should create v1.0.1 release automatically.

Previous failed run: https://github.com/codechu/flow-core-container/actions/runs/17109390650

πŸš€ Automated release system on PR merge to master:
- Semantic versioning based on PR title (feat:/patch/BREAKING CHANGE)
- Auto version bump + commit + tag + GitHub release
- Automated NPM publishing
- Comprehensive release notes with PR details
- Support for major/minor/patch version detection
🎯 Enhanced automated release workflow:
- First release (0.0.0) always bumps to 1.0.0
- Subsequent releases follow semantic versioning
- Perfect for clean release numbering from start
πŸ›‘οΈ Safe + Smart Automated Versioning:

βœ… Manual Override: [patch|minor|major] syntax
βœ… Exact Prefix Matching: Prevents false positives
βœ… Safe Default: Unknown patterns β†’ PATCH
βœ… Smart Detection:
   πŸ”΄ MAJOR: BREAKING CHANGE:|breaking:|MAJOR:|NEW VERSION:
   🟑 MINOR: feat:|feature:|add:|enhance:
   🟒 PATCH: Everything else (safe)

Examples:
- 'feat: New interface' β†’ v1.1.0
- 'NEW VERSION: Architecture' β†’ v2.0.0
- 'fix: Bug [major]' β†’ v2.0.0 (manual)
- 'Random text' β†’ v1.0.1 (safe default)
πŸ› Fixed heredoc shell escaping problem:
- Direct GitHub expression interpolation in EOF block
- Avoids shell variable expansion conflicts with PR body content
- Prevents 'command not found' errors from bullet points
- Release notes generation now safely handles all PR content
βœ… Resolved merge conflict between dev and master
βœ… Kept fixed version (direct GitHub expressions in EOF)
βœ… Eliminated shell variable expansion issues
βœ… Ready for testing automated release pipeline
@obarlik
obarlik merged commit f35ff33 into master Aug 20, 2025
3 checks passed
github-actions Bot added a commit that referenced this pull request Aug 20, 2025
Automated version bump from PR merge (#3)
Author: @obarlik
Type: patch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant