Let's a user share their WebID via a QR code#707
Conversation
|
I see that this PR is based on #706. I would merge the other PR first into development then rebase this branch to line up with Development. Should be good to review after that. |
| /** | ||
| * | ||
| * @param root0 | ||
| * @param root0.webId | ||
| */ |
There was a problem hiding this comment.
Would update this to be a proper JSDoc comment, check other components for reference. The Modal components have very nice examples to follow.
|
The feature looks good, had just checked it on my local machine. |
|
I've found a solution to the failing check in the CI/CD process, see #708. Think we can revert some of the changes you made to |
|
I updated the component's documentation based on the examples from the other modal components and reverted the changes I had made to ci.yml. I'm still getting a failed build check, but I think that's because this branch doesn't have the updated NPM package patches from #708 yet |
leekahung
left a comment
There was a problem hiding this comment.
Sweet! I think we're in the clear.
This PR:
Resolves #691
1. Added a new button labeled "Show QR Code" on the user's Profile page, which opens a modal containing a scannable QR code of the user's webID using a library called react-qr-code. Their WebID is also displayed underneath the code for easy verification.
Screenshots (if applicable):
Additional Context (optional):
This has currently only been tested on a localhost WebID but should work with other pods.
Future Steps/PRs Needed to Finish This Work (optional):