Skip to content

v1.6.0: harden audit comment ingestion - #1107

Merged
jeffhuber merged 4 commits into
mainfrom
codex/1104-audit-comment-ingestion
Sep 22, 2026
Merged

jeffhuber merged 4 commits into
mainfrom
codex/1104-audit-comment-ingestion

Conversation

@jeffhuber

Copy link
Copy Markdown
Contributor

Audit consumers previously decoded GitHub comment history through the 256 KiB private-context path, while the generated gate used an unbounded slurp. A sufficiently long audit history could therefore fail closed inconsistently or consume unbounded data, and literal marker names in prose or Markdown examples could be mistaken for lineage controls.

This change adds one bounded, payload-aware history reader for local audits, hosted labelers, lane status, gate health, and the generated gate. It adapts page size by restarting at page 1, enforces per-response/item/page/aggregate budgets, proves a terminal page, and rejects duplicate or changed IDs across a stable reread. It also recognizes lineage controls only as exact standalone HTML comments outside fenced Markdown, while malformed controls from trusted authorities still fail closed.

Validation:

  • 550 passed, 2074 subtests passed across the affected audit, lineage, gate, workflow, packaging, and release suites
  • Ruff, actionlint, privacy scan, workflow guard, generated artifact checks, documentation lifecycle, release facts, and compile checks pass

Closes #1104

@jeffhuber jeffhuber added builder:codex Code Mower generated label needs-claude-audit labels Sep 22, 2026
@gitar-bot

gitar-bot Bot commented Sep 22, 2026

Copy link
Copy Markdown

Note

Automatic reviews are paused because your team has used its included automatic processing for this billing period (headroom scales with your seat count). You can still comment "Gitar review" to run one anytime, and automatic reviews resume on their own by October 1. Add seats for more headroom.
Learn more

Code Review ✅ Approved

🟡 Medium risk · Broad bounded comment-ingestion changes alter audit, labeling, and gate behavior

Hardens audit comment ingestion by adding a bounded, payload-aware history reader with per-response/item/page/aggregate budgets, page size adaptation, terminal page validation, and duplicate ID detection. Recognizes lineage controls only as exact standalone HTML comments outside fenced Markdown to prevent false positives from literal marker names in prose. All audit, lineage, gate, workflow, packaging, and release tests pass. No issues found.

Review coverage

📋 Rules No rules evaluated

🧪 Functional validation Not enabled · Set up

Options

Display: compact → Counting what did not apply, without listing it.

Comment with these commands to change the behavior for this request:

Compact
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

@github-actions

github-actions Bot commented Sep 22, 2026

Copy link
Copy Markdown

Claude audit (merge-authority lane)

Head SHA: ec191e1e6455a71b19e7b4525515e98f11bb0dc6
Verdict: BLOCKED
Review details remain in the local audit artifact.
Publication workflow: .github/workflows/local-audit-publication.yml at 9f6a89dd717e70946fd6445ecb8c87ebf4244137

@jeffhuber
jeffhuber force-pushed the codex/1104-audit-comment-ingestion branch from 69ca09f to 084d649 Compare September 22, 2026 01:16
@github-actions

Copy link
Copy Markdown

Code Mower notice: previously audited head ec191e1e6455 is no longer an ancestor of current head 084d64908e6b; commits may have been dropped. Only current-head audit verdicts count.

@github-actions

github-actions Bot commented Sep 22, 2026

Copy link
Copy Markdown

Claude audit (merge-authority lane)

Head SHA: 084d64908e6b33ec3960ba93cb848a8cd5d0cb41
Verdict: BLOCKED
Review details remain in the local audit artifact.
Publication workflow: .github/workflows/local-audit-publication.yml at 3cfd554ec3e63356d97ea44ea7453531b9b33fbd

@github-actions

Copy link
Copy Markdown

Code Mower notice: previously audited head ec191e1e6455 is no longer an ancestor of current head d1a19435b1b1; commits may have been dropped. Only current-head audit verdicts count.

@github-actions

github-actions Bot commented Sep 22, 2026

Copy link
Copy Markdown

Claude audit (merge-authority lane)

Head SHA: d1a19435b1b14eb3b11073221c8acd4f597918cf
Verdict: BLOCKED
Review details remain in the local audit artifact.
Publication workflow: .github/workflows/local-audit-publication.yml at 3cfd554ec3e63356d97ea44ea7453531b9b33fbd

@github-actions

Copy link
Copy Markdown

Code Mower notice: previously audited head ec191e1e6455 is no longer an ancestor of current head 0d7967556621; commits may have been dropped. Only current-head audit verdicts count.

@github-actions

Copy link
Copy Markdown

Code Mower notice: previously audited head ec191e1e6455 is no longer an ancestor of current head 0d7967556621; commits may have been dropped. Only current-head audit verdicts count.

@github-actions

github-actions Bot commented Sep 22, 2026

Copy link
Copy Markdown

Claude audit (merge-authority lane)

Head SHA: 0d7967556621b9d3c983b778de47aa23a16e434e
Verdict: PASS
Review details remain in the local audit artifact.
Publication workflow: .github/workflows/local-audit-publication.yml at 3cfd554ec3e63356d97ea44ea7453531b9b33fbd

@jeffhuber
jeffhuber merged commit 166013b into main Sep 22, 2026
22 checks passed
@jeffhuber
jeffhuber deleted the codex/1104-audit-comment-ingestion branch September 22, 2026 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

builder:codex Code Mower generated label claude-audit-done

Projects

None yet

Development

Successfully merging this pull request may close these issues.

v1.6.0: make audit comment ingestion payload-aware

1 participant