Move localized prompts into a separate file#35
Open
pixelomer wants to merge 1 commit intocodenoid:mainfrom
Open
Move localized prompts into a separate file#35pixelomer wants to merge 1 commit intocodenoid:mainfrom
pixelomer wants to merge 1 commit intocodenoid:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request moves localized prompts into a
localization.jsfile. This simplifies the addition of more languages in the future and cleans up the code for HTTP routes. Moving localization data into its own file will also prevent future oversights or mistakes such as the one seen here: 267ca81(This pull request conflicts with the currently open pull requests #33 and #32.)