Leaving <p> tag accessible to screen readers#52
Open
DalisonCPU wants to merge 1 commit intocodenoid:mainfrom
Open
Leaving <p> tag accessible to screen readers#52DalisonCPU wants to merge 1 commit intocodenoid:mainfrom
DalisonCPU wants to merge 1 commit intocodenoid:mainfrom
Conversation
adlai
reviewed
Sep 15, 2024
adlai
left a comment
adlai
left a comment
There was a problem hiding this comment.
I neither read nor approve the repository owner's opinions.
Author
|
What's wrong with this pull request? It is correct and I have already done a test using a screen reader. |
I'm not qualified to negative-acknowledge, only commenting and worrying about unforseen consequences. Thank you for including the purpose of the emphasis. By keeping conversation lively and spicey, I hope the improvement is deployed soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added aria-live="assertive" attribute to the
tag, so that the screen reader automatically announces the loaded text when the "roast" appears.