Skip to content

update ImmuClientverifiedGet to return VerifiableEntry instead ofEntry - #79

Merged
vchaindz merged 2 commits into
codenotary:masterfrom
artiomi:immu4j-verified-entity-return
Jul 26, 2026
Merged

vchaindz merged 2 commits into
codenotary:masterfrom
artiomi:immu4j-verified-entity-return

Conversation

@artiomi

@artiomi artiomi commented Jul 25, 2026

Copy link
Copy Markdown
Contributor

Hello
Current implementation of rpc VerifiableGet returns instance of type VerifiableEntry. At same time ImmuClient.verifiedGet return instance of type Entry.
Considering fact that that VerifiableEntry is a more complex class than Entry, ex: it contains more details about transaction in VerifiableTx, I have added new classes VerifiableEntry, VerifiableTx which now match rpc call response and update ImmuClient.verifiedGet to return VerifiableEntry instance.
In order to avoid impact on existing library users, VerifiableEntry extends Entry class.

Artiom

artiomi added 2 commits July 25, 2026 15:25
…s per schema.proto rpc VerifiableGet

(cherry picked from commit be6c674)
…ch supports all current properties and make Entry immutable

@vchaindz vchaindz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, this addresses everything cleanly.

Thanks for signing the commits too.

@vchaindz
vchaindz merged commit e2cf518 into codenotary:master Jul 26, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants