update ImmuClientverifiedGet to return VerifiableEntry instead ofEntry - #79
Merged
vchaindz merged 2 commits intoJul 26, 2026
Merged
Conversation
…s per schema.proto rpc VerifiableGet (cherry picked from commit be6c674)
…ch supports all current properties and make Entry immutable
vchaindz
approved these changes
Jul 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello
Current implementation of
rpc VerifiableGetreturns instance of typeVerifiableEntry. At same timeImmuClient.verifiedGetreturn instance of typeEntry.Considering fact that that
VerifiableEntryis a more complex class thanEntry, ex: it contains more details about transaction inVerifiableTx, I have added new classesVerifiableEntry,VerifiableTxwhich now match rpc call response and updateImmuClient.verifiedGetto returnVerifiableEntryinstance.In order to avoid impact on existing library users,
VerifiableEntryextendsEntryclass.Artiom