🤖 feat: add caching to file explorer #1783
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Cache expanded folders and folder entries in localStorage - Add LRU file content cache with 50 entry limit and 30min TTL - Show refresh indicator when background-refreshing cached files - Extend text file viewer gutter/background to fill container - Add file path to tab tooltips and status bars Stale-while-revalidate pattern: cached content displays instantly, background fetch updates if changed.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d6d2b8a2a7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
- Use TextEncoder/TextDecoder for Unicode support - Remove redundant textContent field - Add test for Unicode content
Member
Author
|
@codex review |
deansheather
force-pushed
the
file-explorer-490p
branch
from
cefeaed to
a7d70e6
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fdf7e97019
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
- Light theme: bg-black/5 for subtle contrast - Dark theme: bg-black/20 for more visible contrast - Fix eslint exhaustive-deps warning
deansheather
force-pushed
the
file-explorer-490p
branch
from
a7d70e6 to
3f2ea89
Compare
ethanndickson
pushed a commit
that referenced
this pull request
Jan 20, 2026
## Summary Add localStorage-based caching to the file explorer using stale-while-revalidate pattern. Cached content displays instantly when switching tabs, then refreshes in background. ## Changes ### Caching - **Expanded folders**: Persisted with `usePersistedState` - remembers which folders are expanded across tab switches - **Folder entries**: Cached in localStorage, initialized from cache on mount - **File contents**: New LRU cache (`fileContentCache.ts`) with 50 entry limit and 30-minute TTL ### UX Improvements - **Refresh indicator**: Spinning refresh icon when background-refreshing cached file content - **File viewer styling**: Gutter and text area backgrounds now extend to fill container height - **File path display**: Added to tab tooltips (with keybind) and file viewer status bars ### Tests - Added 18 unit tests for `fileContentCache.ts` covering: - Basic CRUD operations - TTL expiration - LRU eviction - Edge cases ## Stale-While-Revalidate Flow 1. Tab switch → render cached content immediately (no spinner) 2. Background fetch kicks off 3. Cache updates when fresh data arrives 4. Component re-renders if content differs --- _Generated with `mux` • Model: `mux-gateway:anthropic/claude-opus-4-5` • Thinking: `high` • Cost: `$12.63`_
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add localStorage-based caching to the file explorer using stale-while-revalidate pattern. Cached content displays instantly when switching tabs, then refreshes in background.
Changes
Caching
usePersistedState- remembers which folders are expanded across tab switchesfileContentCache.ts) with 50 entry limit and 30-minute TTLUX Improvements
Tests
fileContentCache.tscovering:Stale-While-Revalidate Flow
Generated with
mux• Model:mux-gateway:anthropic/claude-opus-4-5• Thinking:high• Cost:$12.63