Skip to content

Fix positron app button so it shows in coder #692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
geniass wants to merge 1 commit into from
+8 −8
Closed

Fix positron app button so it shows in coder #692

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions registry/cytoshahar/modules/positron/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,29 +41,29 @@ variable "group" {
variable "slug" {
type = string
description = "The slug of the app."
default = "cursor"
default = "positron"
}

variable "display_name" {
type = string
description = "The display name of the app."
default = "Cursor Desktop"
default = "Positron Desktop"
}

data "coder_workspace" "me" {}
data "coder_workspace_owner" "me" {}

module "vscode-desktop-core" {
source = "registry.coder.com/coder/vscode-desktop-core/coder"
version = "1.0.0"
version = "1.0.1"

agent_id = var.agent_id

coder_app_icon = "/icon/positron.svg"
coder_app_slug = var.slug
coder_app_display_name = var.display_name
coder_app_order = var.order
coder_app_group = var.group
web_app_icon = "https://github.com/posit-dev/positron/raw/4b8cc97a7a7a9468c02cd5ac0ee685192030825d/src/vs/workbench/browser/media/positron-icon.svg"
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Avoid external icon URL for app icon

The module now hardcodes web_app_icon to a GitHub raw URL. In air‑gapped deployments or environments where GitHub is blocked, the Coder app icon will fail to load because the browser cannot fetch the external asset. This repo’s AGENTS.md also notes “URLs must be relative, not absolute,” which suggests validation/standards expect local assets. Consider adding the icon to the repo (e.g., .icons/) and referencing a relative /icon/... path instead to avoid a runtime dependency on GitHub.

Useful? React with 👍 / 👎.

Copy link
Member

@matifali matifali Feb 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@geniass, can you address this, please? Otherwise LGTM. Will review again.

web_app_slug = var.slug
web_app_display_name = var.display_name
web_app_order = var.order
web_app_group = var.group

folder = var.folder
open_recent = var.open_recent
Expand Down