feat: add RDP keep-alive to windows-rdp module#697
Draft
samuel-asleep wants to merge 1 commit intocoder:mainfrom
Draft
feat: add RDP keep-alive to windows-rdp module#697samuel-asleep wants to merge 1 commit intocoder:mainfrom
samuel-asleep wants to merge 1 commit intocoder:mainfrom
Conversation
Member
|
@samuel-asleep, please attach a video demoing this as described in #213 |
Author
|
@matifali OK will do, but In the meantime I'll convert this pr to draft |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds optional keep-alive functionality to automatically extend workspace sessions during active RDP connections. Uses background PowerShell script to monitor port 3389 and reports activity via
coder stat connectivity.Type of Change
Module Information
Path:
registry/coder/modules/windows-rdpNew version:
v1.4.0Breaking change:
Changes
Variables:
keepalive(bool, default: false) - enables RDP connection monitoringkeepalive_interval(number, default: 300) - check interval in secondsImplementation:
coder_scriptresource spawns background PowerShell processGet-NetTCPConnection -LocalPort 3389 -State Establishedcoder stat connectivityon active connections to extend deadlinestart_blocks_login = falseto avoid delaying workspace startupTests:
Usage
Testing & Validation
bun test)bun fmt)Issues/claim