Modernize build tooling: esbuild + pnpm and add multi-version CI testing #716
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add esbuild.mjs build configuration - Update build/watch/package scripts to use esbuild - Enable caching for prettier and eslint commands - Remove webpack, ts-loader, and eslint-plugin-prettier
EhabY
force-pushed
the
speed-up-build
branch
2 times, most recently
from
232ada8 to
0c0946b
Compare
EhabY
changed the title
- Bundle openpgp as CJS to avoid ESM runtime errors - Add type checking to build scripts - Fix iconPath to use vscode.Uri.file() - Update @types/node, @types/vscode, and VS Code engine to 1.95.0
- Run unit tests against Electron 32 and latest via matrix - Add integration test job for VS Code 1.95.0 and stable - Add test-electron.sh script for version-specific test runs
code-asher
approved these changes
Jan 13, 2026
Comment on lines
+56
to
+62
| - name: Run tests with Electron ${{ matrix.electron-version }} | ||
| run: ./scripts/test-electron.sh ${{ matrix.electron-version }} | ||
| env: | ||
| CI: true | ||
|
|
||
| test-integration: | ||
| name: Integration Test (VS Code ${{ matrix.vscode-version }}) |
| }, | ||
|
|
||
| // Webpack config - CommonJS with Node globals | ||
| // Build config - ESM with Node globals |
Member
There was a problem hiding this comment.
This could be me being dense but it looks like the esbuild.mjs outputs CJS, not ESM like implied in this comment?
Or is this just saying that the build config itself is ESM, not that the output of it is ESM?
| @@ -0,0 +1,9 @@ | |||
| # Native modules allowed to run install scripts (pnpm blocks by default for security) | |||
Member
There was a problem hiding this comment.
Oh interesting, did not know about this. Definitely a plus for pnpm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR modernizes the build infrastructure, resulting in >2x faster CI builds through better caching (pnpm) and faster tooling (esbuild).
Build System
esbuild.mjsconfiguration with watch mode support and openpgp CJS alias fixPackage Manager Migration
--cache --cache-strategy content)CI/CD Improvements
pnpm/action-setup@v4with built-in cachingnpm install -g @vscode/vsce- use local devDependency insteadscripts/test-electron.shfor version-specific test runsOther Changes