Skip to content

🤖 fix: allow local macOS builds and require signing for releases #4110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
coadler wants to merge 3 commits into
base: main
Choose a base branch
from
+12 −4
Open

🤖 fix: allow local macOS builds and require signing for releases #4110

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
933dfb1
🤖 fix: allow macOS builds without signing credentials
coadler Sep 6, 2026
28792b6
🤖 fix: require code signing for official macOS releases
coadler Sep 6, 2026
cbd7882
🤖 fix: exclude Codex status summaries from unresolved findings
coadler Sep 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/_desktop-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,9 @@ jobs:
- name: Package for macOS
# Retry for transient Apple timestamp-server failures during code signing.
run: ./scripts/retry.sh 3 30 make dist-mac
env:
# Local/PR builds may be unsigned, but official releases must fail without signing.
MAC_FORCE_CODE_SIGNING: "true"

- name: Create legacy mux artifact aliases
run: ./scripts/create-legacy-mux-artifact-aliases.sh
Expand Down
11 changes: 7 additions & 4 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -470,6 +470,8 @@ test-e2e-perf: ## Run automated performance profiling scenarios
@XUM_E2E_RUN_PERF=1 XUM_PROFILE_REACT=1 XUM_E2E_LOAD_DIST=1 XUM_E2E_SKIP_BUILD=1 PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD=1 bun x playwright test --project=electron tests/e2e/scenarios/perf*.spec.ts $(PLAYWRIGHT_ARGS)

## Distribution
MAC_FORCE_CODE_SIGNING ?= false

dist: build ## Build distributable packages
@bun x electron-builder --publish never

Expand All @@ -494,13 +496,14 @@ ensure-mac-sharp-runtime-deps: node_modules/.installed

dist-mac: build ## Build macOS distributables (x64 + arm64)
@$(MAKE) --no-print-directory ensure-mac-sharp-runtime-deps
@if [ -n "$$CSC_LINK" ]; then \
@# Local builds may omit signing credentials; keep the check safe under bash -u.
@if [ -n "$${CSC_LINK:-}" ]; then \
Comment thread
coadler marked this conversation as resolved.
echo "🔐 Code signing enabled - using unified build for correct yml..."; \
bun x electron-builder --mac --x64 --arm64 --publish never; \
bun x electron-builder --mac --x64 --arm64 --publish never --config.forceCodeSigning=$(MAC_FORCE_CODE_SIGNING); \
else \
echo "Building macOS architectures in parallel..."; \
bun x electron-builder --mac --x64 --publish never & pid1=$$! ; \
bun x electron-builder --mac --arm64 --publish never & pid2=$$! ; \
bun x electron-builder --mac --x64 --publish never --config.forceCodeSigning=$(MAC_FORCE_CODE_SIGNING) & pid1=$$! ; \
bun x electron-builder --mac --arm64 --publish never --config.forceCodeSigning=$(MAC_FORCE_CODE_SIGNING) & pid2=$$! ; \
wait $$pid1 && wait $$pid2; \
fi
@echo "✅ Both architectures built successfully"
Expand Down
2 changes: 2 additions & 0 deletions scripts/check_codex_comments.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,9 +83,11 @@ compute_codex_sets_from_arrays() {
# JSON goes through stdin, never argv: a long review history exceeds Linux's
# per-argument limit (MAX_ARG_STRLEN, ~128KB) and made --argjson fail with
# "Argument list too long". printf is a shell builtin, so it has no such limit.
# The bot's live status summary is metadata; its findings are gated by review threads below.
REGULAR_COMMENTS=$(printf '%s' "$comments_json" | jq -c --arg bot "$BOT_LOGIN_GRAPHQL" '[
.[]
| select(.author.login == $bot and .isMinimized == false and (.body | test("Didn.t find any major issues|usage limits have been reached|create a Codex account") | not))
| select(.body | startswith("<!-- codex-pull-request-review-summary -->") | not)
]')

UNRESOLVED_THREADS=$(printf '%s' "$threads_json" | jq -c --arg bot "$BOT_LOGIN_GRAPHQL" '[
Expand Down
Loading