Use total_cmp for floats#4
Draft
DanikVitek wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there. I was experimenting on a solution that would be more robust for floats (in case of NaN values). There is a method defined for floats in
std, calledtotal_cmp, that allows for total ordering of NaN values, but I had to implement a customtraitto use theis_arithmetic_progressionfor all applicable types.Unfortunately, the blanket
impl<T: Ord> TotalOrd for Tis not possible to be used together with a separateimplfor floats, due to the "possible future implementation ofOrdon{float}" (which will never happen, but oh well). I guess this could probably be solved with the trait specialization nightly feature...To reduce repetitions, I've made the
macro_rules!declarative macros which generate theimplblocks for all integers and floats. Theimpl_intmacro could also be used for any otherimpl Ordtype, but only manually...I'm not sure the solution is that good to be merged, so just a draft PR.