fix: re-sync mobile domain panel overflow fix from framework - #124
Conversation
Pulls in the App.svelte fix from codeslash-dev/SLASHED#464: the domain panel used w-full + shrink-0 in the same flex row as the icon nav rail, so it demanded 100% of the whole row's width instead of just the space left after the rail — overflowing the viewport by the rail's width with no scrollbar. Now flex-1 min-w-0 on mobile so it fills only what's actually left; desktop keeps its fixed 360px width via md:flex-none. Same root cause affects the WP admin Tokens page on mobile, independent of the earlier embedded-sizing fix (#122). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SQXr34nocCi1jrGcp5TPVm
|
Warning Review limit reached
Next review available in: 59 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThis PR updates the vendored manifest to reference local configurator files instead of GitHub main branch, relocates the mobile fold toggle bar in App.svelte to appear under the header instead of at the bottom, adjusts left panel layout classes, and adds document registration for live preview resolution in AppOverlay.svelte. ChangesAdmin App UI and Vendoring Updates
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested labels: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
PR Summary by QodoFix mobile admin-app domain panel flex overflow (sync from framework)
AI Description
Diagram
High-Level Assessment
Files changed (4)
|
Pulls in the App.svelte change from codeslash-dev/SLASHED#464: the mobile Controls/Preview toggle moved from the very bottom of the screen (below the domain panel, above the status bar) to directly under the header, so it's reachable without scrolling on tall phones. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SQXr34nocCi1jrGcp5TPVm
Code Review by Qodo
Context used✅ Compliance rules (platform):
1 rule 1. Vendored App.svelte modified
|
…rlay The Semantic colors grid (and every other swatch that resolves real computed colors via previewResolver) rendered completely blank on the WP frontend overlay, while the same panel works correctly in WP admin and standalone. previewResolver only has values to resolve once something calls registerPreviewDoc() — normally done by PreviewPanel against its dedicated preview iframe. AppOverlay has no such iframe (the host page itself is the live preview, per class-frontend-configurator.php), so that registration never happened: resolveColor()/resolveColorForTheme() always returned "", and every swatch fell back to "transparent". Register document itself (where injectLivePreview() already applies the live :root overrides) whenever overrides change, so panels resolve against the real page instead of nothing. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SQXr34nocCi1jrGcp5TPVm
There was a problem hiding this comment.
🧹 Nitpick comments (1)
SLASHED-for-WP/admin-app/src/App.svelte (1)
263-285: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueMinor duplication in toggle buttons.
The two toggle buttons share nearly identical structure/classes. Could extract a small reusable button snippet, but given the small, self-contained scope this is optional.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@SLASHED-for-WP/admin-app/src/App.svelte` around lines 263 - 285, The mobile toggle buttons in App.svelte are nearly identical, so reduce duplication by extracting the shared button structure/styling into a small reusable snippet or helper and parameterizing the label, icon, active state, and click handler. Keep the existing mobileView logic and overridesCount badge behavior intact while consolidating the repeated button markup used for the controls and preview toggles.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@SLASHED-for-WP/admin-app/src/App.svelte`:
- Around line 263-285: The mobile toggle buttons in App.svelte are nearly
identical, so reduce duplication by extracting the shared button
structure/styling into a small reusable snippet or helper and parameterizing the
label, icon, active state, and click handler. Keep the existing mobileView logic
and overridesCount badge behavior intact while consolidating the repeated button
markup used for the controls and preview toggles.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 16319fc0-2d24-4a6e-b536-ab032071eddc
📒 Files selected for processing (5)
SLASHED-for-WP/admin-app/.vendored-manifest.jsonSLASHED-for-WP/admin-app/src/App.svelteSLASHED-for-WP/admin-app/src/AppOverlay.svelteSLASHED-for-WP/assets/admin-app/app.cssSLASHED-for-WP/assets/admin-app/app.js
Pulls in the App.svelte change from codeslash-dev/SLASHED#465: extracts the near-duplicate Controls/Preview mobile toggle buttons (CodeRabbit nitpick on this PR) into a single foldToggleButton snippet. No behavior change. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SQXr34nocCi1jrGcp5TPVm
Summary
App.sveltefrom the framework fix in fix(configurator): stop mobile domain panel overflowing past the icon rail SLASHED#464.w-full(100% of the whole row, not the space remaining after the rail) plusshrink-0(refusing to shrink). The row then demanded more width than the viewport had, silently clipping content on the right with no scrollbar (app root usesoverflow-hidden).flex-1 min-w-0on mobile so the panel fills only the space actually left after the rail;md:flex-nonekeeps the desktop fixed-360px behavior unchanged.assets/admin-app/app.js/app.css).Type
Checklist
feat:,fix:,docs:, …)npm test(not run — requires WP test harness not available in this environment;npm run lintandnpm run verifywere run instead)npm run lintpasses (stylelint +php -l)npm run verifypasses (version metadata in sync)assets/admin-app/app.js/app.cssregenerated vianpm run build:admin-app)CHANGELOG.mdupdated under## [Unreleased]— not done, let me know if you'd like this addedadmin-app/srcsource changed via sync)Notes
Depends on codeslash-dev/SLASHED#464 (framework half of this fix), synced via
SLASHED_CONFIGURATOR_SRC=/path/to/SLASHED/configurator/src npm run sync.🤖 Generated with Claude Code
https://claude.ai/code/session_01SQXr34nocCi1jrGcp5TPVm
Generated by Claude Code
Summary by CodeRabbit