docs: add technical debt audit - #469
jackgranatowski wants to merge 2 commits into
Conversation
Full 9-dimension audit of core/, optional/, configurator/, scripts/, tests/, and docs/. 34 findings (0 Critical, 1 High, 15 Medium, 18 Low), verified against clean tsc/svelte-check/stylelint/madge/npm-audit baselines. Highest-impact items: zero test coverage on the configurator's interactive layer, deliberately obfuscated codec.ts naming, and duplicated parsing helpers across the doc-gen scripts. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013cK9t8cQQn4DNweTjJzVZi
Sequenced, multi-PR plan covering all 71 findings from both repos' audits: 7 themed PRs for SLASHED and ~13 for SLASHED-Plugins, grouped by risk/theme with explicit dependency ordering (framework fixes land first, then the plugin syncs the vendored copy). Cross-links the plan from each audit doc. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013cK9t8cQQn4DNweTjJzVZi
|
Warning Review limit reached
Next review available in: 17 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
PR Summary by QodoDocs: add technical debt audit and sequenced remediation plan
AI Description
Diagram
High-Level Assessment
Files changed (2)
|
Code Review by Qodo
Context used✅ Compliance rules (platform):
6 rules 1. Non-portable plan commands
|
| cd /home/user/SLASHED | ||
| npm run docs && cp docs/api-index.json token-registry.json "$TMPDIR/audit-verify-before/" |
There was a problem hiding this comment.
1. Non-portable plan commands 🐞 Bug ⚙ Maintainability
docs/technical-debt-remediation-plan.md hardcodes local absolute paths (e.g. /home/user/SLASHED) and instructs copying to "$TMPDIR/audit-verify-before/" without ensuring that directory exists, so the verification steps can fail when followed verbatim. This reduces the plan’s usefulness as a repeatable procedure for other contributors and CI environments.
Agent Prompt
### Issue description
The remediation plan contains copy/paste commands that are environment-specific and can fail:
- Uses hardcoded absolute paths like `/home/user/SLASHED`.
- Copies into `"$TMPDIR/audit-verify-before/"` without creating the directory.
### Issue Context
These commands are meant to be executed by other contributors and in different environments; they should work regardless of checkout location.
### Fix Focus Areas
- docs/technical-debt-remediation-plan.md[9-12]
- docs/technical-debt-remediation-plan.md[78-86]
### Suggested change
- Replace `cd /home/user/SLASHED` with a portable alternative, e.g.:
- `cd "$(git rev-parse --show-toplevel)"`
- or instruct setting `SLASHED_ROOT` and using `cd "$SLASHED_ROOT"`
- Replace the `cp ... "$TMPDIR/audit-verify-before/"` pattern with a created temp dir, e.g.:
- `audit_dir="$(mktemp -d)"`
- `cp ... "$audit_dir/"`
- (or `mkdir -p "$TMPDIR/audit-verify-before"` before copying).
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
Full 9-dimension audit of core/, optional/, configurator/, scripts/,
tests/, and docs/. 34 findings (0 Critical, 1 High, 15 Medium, 18 Low),
verified against clean tsc/svelte-check/stylelint/madge/npm-audit
baselines. Highest-impact items: zero test coverage on the configurator's
interactive layer, deliberately obfuscated codec.ts naming, and
duplicated parsing helpers across the doc-gen scripts.
Co-Authored-By: Claude Sonnet 5 noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_013cK9t8cQQn4DNweTjJzVZi