test(configurator): fix header.test.js saved-state test claim (CodeRabbit finding on #474)

[jackgranatowski]

Summary

Small follow-up fixing a CodeRabbit finding surfaced on #474 (the aggregate PR) against a test added in already-merged PR7 (#481).

The 'saved' state test in tests-components/header.test.js claimed to verify "a distinct title from a fresh, unattempted save," but queries the exact same title text ('No unsaved changes') as the idle test — the two states are only ever distinguished by button label text ('Saved' vs 'Save'), never by title. Renamed the test to describe what it actually asserts, since the title overlap is correct existing StudioHeader behavior (a saveState: 'saved' with no pending changes legitimately shares idle's title) — not a bug to fix in the component.

Test plan

• npx vitest run tests-components/header.test.js — 11/11 passed

---

Generated by Claude Code

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 187685c2-0912-4b20-8e90-fd958ffe343f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch claude/fix-header-test-title-claim

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[qodo-code-review]

PR Summary by Qodo

Fix misleading saved-state test name in StudioHeader header.test.js

🧪 Tests 🕐 Less than 5 minutes

AI Description

• Rename saved-state StudioHeader test to match what it actually asserts.
• Clarify that saved and idle states legitimately share the same title text.

Diagram

graph TD
  A["header.test.js"] --> B["StudioHeader"] --> C["DOM queries/assertions"]
  subgraph Legend
    direction LR
    _t["Test"] ~~~ _c["Component"] ~~~ _a["Assertion"]
  end

Loading

High-Level Assessment

The chosen approach (rename the test to reflect the actual assertion) is the best fit since the underlying component behavior is correct and the issue is purely a misleading test description; changing the assertion or component would introduce unnecessary behavior changes.

Files changed (1) +1 / -1

Tests (1) +1 / -1

header.test.jsRename saved-state test to reflect correct title expectations +1/-1

Rename saved-state test to reflect correct title expectations

• Updates the saved-state test name to clarify that the title matches the idle/no-pending-changes state while the button label changes to "Saved". No assertions or component behavior are modified.

configurator/tests-components/header.test.js

[qodo-code-review]

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Great, no issues found!

Qodo reviewed your code and found no material issues that require review