fix: dark-mode contrast bugs from the Studio light-mode rollout - #513
Conversation
- SliderRow: the "default: X" helper text used dark:text-slate-700, which gets darker on the dark shell instead of lighter — swap to dark:text-slate-400 so it stays readable. - CheatsheetPanel, HomePanel, ThemesPanel: search/save inputs were missing a dark:placeholder variant, staying at the light-only placeholder:text-slate-600 against the new dark input background. - ThemesPanel: the "No saved themes yet" empty state had no dark: variant at all. Found by CodeRabbit review on SLASHED-Plugins#154.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughThis PR updates Tailwind dark-mode CSS classes across four Svelte components in the configurator app, adjusting text and placeholder colors for improved dark mode readability. No logic, behavior, or component interfaces were changed. ChangesDark Mode Styling Fixes
Estimated code review effort: 1 (Trivial) | ~3 minutes Possibly related PRs
Suggested labels: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
PR Summary by QodoFix dark-mode contrast for placeholders and helper text in Studio configurator
AI Description
Diagram
High-Level Assessment
Files changed (4)
|
- Switch the frontend overlay's theme pin from a raw themeState.value assignment to forceTheme(), now that SLASHED#512 (which added it) is merged. The raw assignment left followSystem enabled, so a later OS prefers-color-scheme change could flip the overlay back to light while it's open (CodeRabbit review finding). - Sync 4 dark-mode contrast fixes from the framework (codeslash-dev/SLASHED#513): SliderRow's inverted helper-text shade, and missing dark:placeholder/text variants in CheatsheetPanel, HomePanel, and ThemesPanel.
Verified live-vs-staged by building the bundle + checking comment state: - SHIPPED (live in core): .sf-corner-scoop (inverted radius, via mask), .sf-overlap (overlap effect), .sf-grid-flex (centered flex-grid) -> close audit 2.3, 14, 8.12 and priorities B27, B11, flex-grid gap. - STAGED (authored but commented in optional/utilities.css): .sf-hover-*, .sf-h1..h6, .sf-z-*, .sf-object-* -> B3 and B7-headings move from 'missing' to 'authored, awaiting un-stage'. .sf-btn/.sf-card/.sf-skeleton still staged. .sf-boxed dropped. - Dark-mode contrast fixes (PR #513) noted against A1. - Corrected the stale 'utilities.css is an empty stub' premise. Plugin: recent PRs infra/tests/marketing/relicense only — no new ACSS parity. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AR8LFdZpCqJj3AaYWM4hB4
Summary
Fixes 4 dark-mode contrast bugs flagged by CodeRabbit review on
codeslash-dev/SLASHED-Plugins#154(which vendors this code), left over from the #506–#510 light-mode rollout.Fixes
default: {rawDefault}helper text useddark:text-slate-700, which is darker than the light-mode value, making it worse on the dark shell instead of better. Swapped todark:text-slate-400.dark:variant, staying atplaceholder:text-slate-600(low contrast on the dark input background). Addeddark:placeholder:text-slate-400.dark:placeholder:*gap on the quick-save input.dark:placeholder:*gap on the save-form input, plus the "No saved themes yet" empty-state text had nodark:variant at all.🤖 Generated with Claude Code
Generated by Claude Code
Summary by CodeRabbit