fix(configurator): correct token metadata drift & misleading help (#684–689) #690
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,7 +2,6 @@ | |
| import SliderRow from '../inputs/SliderRow.svelte'; | ||
| import ColorInput from '../inputs/ColorInput.svelte'; | ||
| import Section from '../inputs/Section.svelte'; | ||
|
|
||
| let { overrides, onSet, onReset, onBulkChange }: { | ||
| overrides: Record<string, string>; | ||
|
|
@@ -27,7 +26,7 @@ | |
| { label: "XS", token: "--sf-size-xs", default: 1.5 }, | ||
| { label: "S", token: "--sf-size-s", default: 2 }, | ||
| { label: "M", token: "--sf-size-m", default: 2.5 }, | ||
| { label: "L", token: "--sf-size-l", default: 3 }, | ||
| { label: "XL", token: "--sf-size-xl", default: 3.5 }, | ||
| ]; | ||
|
|
||
|
|
@@ -64,12 +63,11 @@ | |
| <Section title="Touch target" bind:open={showTouchTarget}> | ||
| <SliderRow | ||
| label="Min touch size" value={touchTarget} min={32} max={64} step={1} unit="px" | ||
| help="--sf-touch-target — minimum tappable area for interactive elements (WCAG 2.5.5). Independent literal (2.75rem / 44px) — deliberately NOT an alias of the --sf-size-* scale, so retuning sizes never drops below the accessibility floor." | ||
| overridden={"--sf-touch-target" in overrides} | ||
| onChange={(v) => onSet("--sf-touch-target", `${v}px`)} | ||
| onReset={() => onReset("--sf-touch-target")} | ||
| rawDefault="2.75rem" | ||
| currentRaw={overrides["--sf-touch-target"]} | ||
| onRawSet={(v) => onSet("--sf-touch-target", v)} | ||
| /> | ||
|
|
@@ -88,8 +86,8 @@ | |
| <!-- Z-INDEX --> | ||
| <Section title="Z-index layers" bind:open={showZIndex}> | ||
| <SliderRow | ||
| label="Base" value={zBaseOffset} min={0} max={1000} step={10} | ||
| help="--sf-z-base — base local-stacking rung (default 0), consumed by the .sf-z-base utility. It is NOT added to the other rungs: every ladder step below is an independent literal." | ||
| overridden={"--sf-z-base" in overrides} | ||
| onChange={(v) => onSet("--sf-z-base", String(v))} | ||
| onReset={() => onReset("--sf-z-base")} | ||
|
Comment on lines
88
to
93
There was a problem hiding this comment.
When a persisted theme contains a
Contributor
Author
There was a problem hiding this comment. Fixed in d33606b. Reverted the slider range back to the original |
||
|
|
@@ -285,7 +283,7 @@ | |
| <!-- ICON SIZES --> | ||
| <Section title="Icon sizes" bind:open={showIconSizes}> | ||
| <p class="text-[10px] text-slate-400 dark:text-slate-600 leading-relaxed"> | ||
| Icon scale tokens used by <span class="font-mono text-slate-600 dark:text-slate-400">.sf-icon--*</span> utilities. Values are in <span class="font-mono text-slate-600 dark:text-slate-400">em</span> units relative to surrounding text. | ||
| </p> | ||
| <div class="space-y-1.5"> | ||
| {#each [ | ||
|
|
@@ -306,7 +304,7 @@ | |
| </div> | ||
| <SliderRow | ||
| label="Box padding" value={parseNum(overrides["--sf-icon-box-pad"]?.replace("em",""), 0.5)} min={0} max={2} step={0.125} unit="em" | ||
| help="--sf-icon-box-pad — padding around icon when using .sf-icon--boxed" | ||
| overridden={"--sf-icon-box-pad" in overrides} | ||
| onChange={(v) => onSet("--sf-icon-box-pad", `${v}em`)} | ||
| onReset={() => onReset("--sf-icon-box-pad")} | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When a persisted or imported
--sf-touch-targetoverride uses2.75remorvar(--sf-size-l), this px-only control displays an out-of-range or fallback value and replaces the original expression with a clamped px literal when edited.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in d33606b. Restored the raw-CSS escape hatch (
currentRaw/onRawSet) with an honest independent literal default (2.75rem) instead of the misleadingvar(--sf-size-l)alias, and no scale picker. Persistedvar()/calc()/clamp()overrides now surface as editable raw text via the</>toggle / expr auto-detect rather than being misread as an out-of-range px value and clobbered to px on edit. This still satisfies #685 (no --sf-size-* alias suggestion).