-
Notifications
You must be signed in to change notification settings - Fork 0
feat(configurator): metadata-driven token→domain classification (UX redesign, phase 2) #692
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jackgranatowski
merged 5 commits into
main
from
ux/configurator-metadata-classification
Aug 20, 2026
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
0d6aa46
feat(configurator): add token relationship model and surface roles/st…
kiro-agent bb94c79
feat(configurator): metadata-driven token→domain classification (sing…
kiro-agent 85d3cc4
fix(configurator): validate token overrides accurately
kiro-agent cb09e36
fix(configurator): qualify default dependency counts
kiro-agent 5d6707b
fix(configurator): align token safety with export limits
kiro-agent File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 changes: 6 additions & 8 deletions
14
configurator/src/components/panels/GenericTokenPanel.svelte
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,106 @@ | ||
| { | ||
| "_doc": "Authoritative, metadata-driven token→domain classification. Keyed on the framework-authored `namespace` (the segment after --sf-), which is precise and never drifts from the framework — unlike the old substring matching, where overlapping fragments (e.g. 'color' in --sf-focus-ring-color) routed a token to the wrong panel and made the sidebar badge, the category Reset, and the All-tokens list disagree. A namespace maps to exactly one domain; the handful of genuinely mixed namespaces are resolved per-token in `exceptions`. Every domain here must also exist in domains.ts's DOMAINS list. check-curation.mjs consumes the same file, so the build guard and the runtime can never diverge.", | ||
| "namespaces": { | ||
| "color": "colors", | ||
| "contrast": "colors", | ||
| "palette": "colors", | ||
| "lumlocker": "colors", | ||
| "gradient": "colors", | ||
| "marker": "colors", | ||
|
|
||
| "text": "typography", | ||
| "font": "typography", | ||
| "body": "typography", | ||
| "heading": "typography", | ||
| "h1": "typography", | ||
| "h2": "typography", | ||
| "h3": "typography", | ||
| "h4": "typography", | ||
| "h5": "typography", | ||
| "h6": "typography", | ||
| "leading": "typography", | ||
| "tracking": "typography", | ||
| "link": "typography", | ||
| "optical": "typography", | ||
| "display": "typography", | ||
| "code": "typography", | ||
| "fluid": "typography", | ||
|
|
||
| "space": "spacing", | ||
| "gap": "spacing", | ||
| "gutter": "spacing", | ||
| "section": "spacing", | ||
| "component": "spacing", | ||
| "content": "spacing", | ||
|
|
||
| "container": "layout", | ||
| "grid": "layout", | ||
| "center": "layout", | ||
| "cluster": "layout", | ||
| "cover": "layout", | ||
| "equal": "layout", | ||
| "frame": "layout", | ||
| "imposter": "layout", | ||
| "reel": "layout", | ||
| "sidebar": "layout", | ||
| "switcher": "layout", | ||
| "alternate": "layout", | ||
| "bento": "layout", | ||
| "stack": "layout", | ||
| "header": "layout", | ||
| "sticky": "layout", | ||
| "safe": "layout", | ||
| "touch": "layout", | ||
| "breakout": "layout", | ||
| "box": "layout", | ||
| "bg": "layout", | ||
| "ratio": "layout", | ||
|
|
||
| "radius": "borders", | ||
| "border": "borders", | ||
| "divider": "borders", | ||
| "field": "borders", | ||
| "media": "borders", | ||
|
|
||
| "shadow": "shadows", | ||
|
|
||
| "motion": "motion", | ||
| "duration": "motion", | ||
| "ease": "motion", | ||
| "transition": "motion", | ||
| "stagger": "motion", | ||
| "scroll": "motion", | ||
| "hover": "motion", | ||
| "theme": "motion", | ||
| "animation": "motion", | ||
|
|
||
| "blur": "effects", | ||
| "opacity": "effects", | ||
| "drop": "effects", | ||
|
|
||
| "prose": "macros", | ||
| "flow": "macros", | ||
| "line": "macros", | ||
| "scrim": "macros", | ||
| "surface": "macros", | ||
| "mask": "macros", | ||
|
|
||
| "btn": "components", | ||
| "card": "components", | ||
|
|
||
| "z": "misc", | ||
| "icon": "misc", | ||
| "size": "misc", | ||
| "object": "misc", | ||
| "scrollbar": "misc", | ||
| "focus": "misc", | ||
| "is": "misc" | ||
| }, | ||
| "exceptions": { | ||
| "--sf-content-width": "layout", | ||
| "--sf-content-intrinsic-size": "macros", | ||
| "--sf-scroll-shadow-size": "macros", | ||
| "--sf-scroll-offset-gap": "layout", | ||
| "--sf-field-required-marker": "misc" | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The dependency graph is built exclusively from catalogue defaults, so relinking a token or replacing a reference with a concrete override leaves the “used by N” guidance stale. Build the graph from effective values or label these counts as default-catalogue relationships.