Skip to content

feat: creating readonly option #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Farenheith wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: creating readonly option #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,15 +8,10 @@ on:
jobs:
build:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [14.x]
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v5
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node-version }}
uses: actions/setup-node@v6
Comment on lines +12 to +14
Copy link

Copilot AI Apr 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This workflow still references matrix.node-version in the step name, but the matrix strategy was removed. Referencing matrix.* without a matrix will fail workflow parsing/execution. Either restore the matrix strategy or remove the ${{ matrix.node-version }} reference (and optionally set an explicit node-version).

Copilot uses AI. Check for mistakes.
- name: install
run: npm ci
- name: Build
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,9 @@ jobs:
lint:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v5
- name: Use Node.js
uses: actions/setup-node@v3
uses: actions/setup-node@v6
- name: install
run: npm ci
- name: Lint
Expand Down
50 changes: 35 additions & 15 deletions .github/workflows/semantic.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,39 +3,59 @@ name: semantic-release
on:
push:
branches: [master]
workflow_dispatch:

permissions:
id-token: write
contents: read

jobs:
semantic:
runs-on: ubuntu-latest
env:
GITHUB_TOKEN: ${{ secrets.GH_TOKEN }}
Copy link

Copilot AI Apr 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This workflow still uses @semantic-release/npm (see .releaserc.json), but NPM_TOKEN is no longer provided anywhere. Unless you’ve switched to an alternative npm auth mechanism, semantic-release will fail when trying to publish. Either restore NPM_TOKEN (or the required env vars for npm auth) or remove/disable the npm plugin if publishing isn’t intended.

Suggested change
GITHUB_TOKEN: ${{ secrets.GH_TOKEN }}
GITHUB_TOKEN: ${{ secrets.GH_TOKEN }}
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}

Copilot uses AI. Check for mistakes.
NPM_TOKEN: ${{secrets.NPM_TOKEN}}
HUSKY: 0
CI: true
steps:
- uses: actions/checkout@master
- uses: actions/checkout@v4
with:
token: ${{ secrets.GH_TOKEN }}
- uses: actions/setup-node@v3
- uses: actions/setup-node@v4
with:
node-version: "14.x"
- run: printf "//`node -p \"require('url').parse('https://registry.npmjs.org').host\"`/:_authToken=${NPM_TOKEN}\n" >> ~/.npmrc
node-version: "lts/*"
- run: npm ci
- run: npm run build --if-present
- name: Redis Server in GitHub Actions
uses: supercharge/redis-github-action@1.1.0
- run: npm test
- uses: actions/setup-node@v3
- name: Upload coverage to Qlty
uses: qltysh/qlty-action/coverage@v2
continue-on-error: true
with:
node-version: "lts/*"
token: ${{ secrets.CC_TEST_REPORTER_ID }}
files: coverage/lcov.info
Comment on lines 26 to +33
Copy link

Copilot AI Apr 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The release workflow no longer runs the test suite (previously npm test with Redis). Relying only on PR checks means direct pushes (or workflow_dispatch) can publish without verification. Consider running at least npm test/npm run test:coverage here (and starting Redis if needed) before invoking semantic-release.

Copilot uses AI. Check for mistakes.
- run: previousVersion=$(sed 's/.*"version": "\(.*\)".*/\1/;t;d' ./package.json)
- run: npm i -g @semantic-release/changelog @semantic-release/commit-analyzer @semantic-release/git @semantic-release/github @semantic-release/exec @semantic-release/npm @semantic-release/release-notes-generator semantic-release
- run: |
Comment on lines 34 to +35
Copy link

Copilot AI Apr 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sed pattern is looking for "version": (HTML entity) instead of the actual JSON "version":. As written, previousVersion/finalVersion will likely be empty, which breaks the conditional git push logic. Update the pattern to match the literal colon (or use node -p "require('./package.json').version" / jq -r .version).

Copilot uses AI. Check for mistakes.
# Install semantic-release and common plugins locally (no-global) so the pipeline can run reliably.
npm install --no-audit --no-fund --no-save \
@semantic-release/changelog \
@semantic-release/commit-analyzer \
@semantic-release/git \
@semantic-release/github \
@semantic-release/exec \
@semantic-release/npm \
@semantic-release/release-notes-generator \
semantic-release
env:
GITHUB_TOKEN: ${{ secrets.GH_TOKEN }}
NPM_TOKEN: ${{secrets.NPM_TOKEN}}
HUSKY: 0
CI: true
- run: npx semantic-release --ci
- run: git push
- run: |
# Run semantic-release using the locally installed packages
npx semantic-release@25 --ci
env:
NPM_TOKEN: ${{secrets.NPM_TOKEN}}
GITHUB_TOKEN: ${{ secrets.GH_TOKEN }}
HUSKY: 0
CI: true
- run: finalVersion=$(sed 's/.*"version": "\(.*\)".*/\1/;t;d' ./package.json)
- run: |
if [ "$previousVersion" != "$finalVersion" ]; then
git push
fi
18 changes: 4 additions & 14 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,23 +8,13 @@ on:
jobs:
test:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [14.x]
steps:
- uses: actions/checkout@v2
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node-version }}
- uses: actions/checkout@v5
- name: Use Node.js
uses: actions/setup-node@v6
- name: install
run: npm ci
- name: Redis Server in GitHub Actions
uses: supercharge/redis-github-action@1.1.0
- name: 'Test'
uses: paambaati/codeclimate-action@v2.6.0
env:
CC_TEST_REPORTER_ID: ${{ secrets.CC_TEST_REPORTER_ID }}
with:
coverageCommand: npm run test:coverage
coverageLocations: ${{github.workspace}}/coverage/lcov.info:lcov
run: npm run test:coverage
75 changes: 0 additions & 75 deletions bitbucket-pipelines.yml
View file
Open in desktop

This file was deleted.

Loading
Loading