Skip to content

Fix Xcode warnings - #15

Merged
coffee-cup merged 3 commits into
mainfrom
codex/fix-xcode-warnings
May 24, 2026
Merged

Fix Xcode warnings#15
coffee-cup merged 3 commits into
mainfrom
codex/fix-xcode-warnings

Conversation

@coffee-cup

Copy link
Copy Markdown
Owner

Fixes the current Xcode warning set without changing runtime behavior.

  • Marks Core Data factory helpers as @discardableResult where callers intentionally rely on insertion side effects.
  • Handles future StoreKit transaction states with @unknown default.
  • Makes small explicit-discard/access-level cleanups for number formatting, color conversion, and confetti color defaults.
  • Aligns the widget extension build and marketing versions with the containing app so embedded extension validation is clean.
  • Root cause: several APIs intentionally return created objects even when some call sites only need the side effect, and the widget target version settings had drifted from the app target.
  • Validated with xcodebuild -quiet -scheme bowtie2 -destination 'generic/platform=iOS' clean build CODE_SIGNING_ALLOWED=NO.

@coffee-cup
coffee-cup marked this pull request as ready for review May 24, 2026 21:55
@coffee-cup coffee-cup changed the title [codex] Fix Xcode warnings Fix Xcode warnings May 24, 2026
@coffee-cup
coffee-cup merged commit 6bbf575 into main May 24, 2026
3 checks passed
@coffee-cup
coffee-cup deleted the codex/fix-xcode-warnings branch May 24, 2026 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant