Repo hardening: fix install instructions, dead imports, hygiene#1
Open
cognis-digital wants to merge 4 commits into
Open
Repo hardening: fix install instructions, dead imports, hygiene#1cognis-digital wants to merge 4 commits into
cognis-digital wants to merge 4 commits into
Conversation
- fix 2 broken `pip install` line(s) in README (package is not on PyPI; use the working git+https install) - remove 4 unused import(s) (ruff F401/F811)
d8d491e to
d44f69f
Compare
added 3 commits
June 13, 2026 03:56
tests/test_smoke.py was importing a v1-era API (analyze_dependencies, analyze_manifest, score_dependency, _edit_distance, _is_below, _typosquat_match, Dependency with pin-string arg, CLI 'scan' command) that no longer exists in the current source. Rewrote the test module to match the real current API (audit_dependency, audit_file, levenshtein, version_compare, typosquat_match, CLI 'audit' command) while preserving assertions on the same real behaviors. All 46 tests now pass. Also added layman.md with a plain-language description, inserted the "What is this?" and "Install" sections into README.md via enrich.py, and updated install.sh + added install.ps1 cross-platform install scripts.
- cli.py: catch ValueError (malformed manifest) and broad Exception in audit command so all error paths print to stderr and return exit 2, never a raw traceback; guard stdin read against UnicodeDecodeError - core.py: _parse_package_json raises ValueError with clear message on invalid JSON or non-object top level, and skips empty-string names; returns empty list for empty input rather than crashing - core.py: _parse_pipfile guards against empty names after stripping and wraps regex logic in try/except for type-safety - core.py: parse_manifest accepts None text (treated as empty string) - core.py: Dependency.max_severity guards against unknown severity strings via try/except on list.index() calls - tests/test_hardening.py: 20 new tests covering empty manifests, malformed JSON, unknown severity, empty-stdin audit, missing files, and CLI error-path exit codes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR applies a few small, mechanically-verified hardening fixes found by an automated audit of the Cognis suite:
pip installline(s) in README (package is not on PyPI; use the working git+https install)Each change is deterministic; all touched Python files were confirmed to still compile (
py_compile) before this PR was opened.