Repo hardening: fix install instructions, dead imports, hygiene#3
Open
cognis-digital wants to merge 5 commits into
Open
Repo hardening: fix install instructions, dead imports, hygiene#3cognis-digital wants to merge 5 commits into
cognis-digital wants to merge 5 commits into
Conversation
- fix 1 broken `pip install` line(s) in README (package is not on PyPI; use the working git+https install) - remove 5 unused import(s) (ruff F401/F811) - add a standard Python .gitignore
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
cognis-digital
force-pushed
the
cognis-audit/repo-hardening
branch
from
0af127c to
7a64e70
Compare
…-06-13) - README install instructions point at the working git+https path - ran the actual audit: 2 tests passed, 0 parse errors, CLI C:\Python314\python.exe: No module named https - embedded results in README ## Verification and AUDIT.md
Insert What-is-this section in README with non-technical description Insert Install section covering pipx, uv, pip, and source install Add install.sh and install.ps1 cross-platform installers Add layman.md with plain-language description
- cli: wrap all subcommand dispatch in try/except; validate slot names before dispatch; catch KeyboardInterrupt; unknown slot -> SystemExit with clear message and non-zero code; empty prompt/task rejected - harness: chat() validates non-empty messages and known slot; converts URLError/TimeoutError to RuntimeError with actionable messages; guards against non-JSON and malformed choices/message/content responses; _run_tool guards empty path/command; agent() rejects empty task and max_steps < 1 - serve: _load() handles corrupt/missing/malformed state.json gracefully; removed unused `st` variable in status() (ruff F841); split multi- statement lines for ruff E701/E702 compliance - download: _direct() now has an explicit timeout (FLEET_DOWNLOAD_TIMEOUT, default 3600s); _hf_lib wraps hf_hub_download in try/except; pull() and model_path() validate slot name before KeyError - memory: _Fallback.remember() skips empty keys; recall() returns [] for empty query; k < 1 clamped to 1 to avoid SQL errors - webhook: validates --url scheme; rejects empty stdin; validates JSON before POST; validates --header format - tests: 22 new tests covering all new error/edge paths (unknown slot, network failure, corrupt state, empty inputs, bad JSON, bad URL) - ruff E/F: fixed multi-import lines, multi-statement lines, unused var
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR applies a few small, mechanically-verified hardening fixes found by an automated audit of the Cognis suite:
pip installline(s) in README (package is not on PyPI; use the working git+https install)Each change is deterministic; all touched Python files were confirmed to still compile (
py_compile) before this PR was opened.