Conversation
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. |
☂️ Python Coverage
Overall Coverage
New Files
Modified Files
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2510 +/- ##
==========================================
+ Coverage 85.83% 85.85% +0.02%
==========================================
Files 410 414 +4
Lines 34222 34387 +165
==========================================
+ Hits 29373 29523 +150
- Misses 4849 4864 +15
🚀 New features to boost your workflow:
|
doctrino
left a comment
There was a problem hiding this comment.
Good stuff. I have commented where I found issues.
In addition, you have to ensure that data products are exempt from smoke tests as all API classes that subclass CDFResourceAPI will automatically be picked up. Thus if this is merged smoke tests will fail.
tests/data/complete_org_alpha_flags/modules/my_example_module/data_products/my.DataProduct.yaml
Outdated
Show resolved
Hide resolved
cognite_toolkit/_cdf_tk/client/resource_classes/data_product.py
Outdated
Show resolved
Hide resolved
cognite_toolkit/_cdf_tk/client/resource_classes/data_product.py
Outdated
Show resolved
Hide resolved
cognite_toolkit/_cdf_tk/client/resource_classes/data_product.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Anders Albert <60234212+doctrino@users.noreply.github.com>
Co-authored-by: Anders Albert <60234212+doctrino@users.noreply.github.com>
Co-authored-by: Anders Albert <60234212+doctrino@users.noreply.github.com>
Co-authored-by: Anders Albert <60234212+doctrino@users.noreply.github.com>
Co-authored-by: Anders Albert <60234212+doctrino@users.noreply.github.com>
…into data-products
…a flag Suppress 404 errors from the data products API when the alpha flag is enabled but the endpoint is not yet available on the test server. Co-authored-by: Cursor <cursoragent@cursor.com>
doctrino
left a comment
There was a problem hiding this comment.
You are missing extending https://github.com/cognitedata/toolkit/blob/main/tests/test_unit/approval_client/config.py#L1314
such that the local deployment of complete org checks for data product
- Extract shared DataProduct base class for request/response models - Rename items -> external_ids on retrieve and delete API methods - Fix list default from None to 10 - Simplify integration test: always exclude DataProductCRUD since alpha flag is off in cdf.toml
The fallback was lost during a merge from main. Without it, deserializing built data product resources fails when DataProductCRUD is excluded from CRUDS_BY_FOLDER_NAME.
Register DataProductsAPI in the approval client config so the complete_org build/deploy unit tests exercise data product CRUD.
The approval client now includes data products, so the build/deploy snapshot needs the expected DataProductResponse output.
| os.environ, | ||
| {"EVENTHUB_CLIENT_ID": client_id, "EVENTHUB_CLIENT_SECRET": client_secret}, | ||
| ), | ||
| patch.dict( |
There was a problem hiding this comment.
This is a good solution.
Description
Data Products alpha feature based on service contract https://github.com/cognitedata/service-contracts/blob/a386f0c1592ce3f8d6b93bb6cf83d0c6443eaf6f/versions/v1/dataproducts.preproc.yml
The Data Product service is available in a limited number of Projects at the moment.
Bump
Changelog
Added