[CDF-27110] 🧱As id method for YAML classes by doctrino · Pull Request #2527 · cognitedata/toolkit

doctrino · 2026-02-16T14:32:46Z

Description

We will use this is in build v2 to get the identifier of each resource.

Bump

Patch
Skip

gemini-code-assist · 2026-02-16T14:32:50Z

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

doctrino · 2026-02-16T14:54:12Z

/gemini review

gemini-code-assist

Code Review

This pull request introduces an abstract as_id() method to the ToolkitResource base class and implements it across numerous YAML resource classes. This provides a standardized way to retrieve an identifier object for each resource. The changes are mostly boilerplate implementations and look correct. I've found one issue with the docstring of the new abstract method in the base class, which should be corrected to avoid confusion.

cognite_toolkit/_cdf_tk/resource_classes/base.py

github-actions · 2026-02-16T14:58:24Z

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines	Covered	Coverage	Threshold	Status
34222	29368	86%	80%	🟢

New Files

No new covered files...

Modified Files

File	Coverage	Status
cognite_toolkit/_cdf_tk/resource_classes/agent.py	94%	🟢
cognite_toolkit/_cdf_tk/resource_classes/asset.py	94%	🟢
cognite_toolkit/_cdf_tk/resource_classes/base.py	100%	🟢
cognite_toolkit/_cdf_tk/resource_classes/cognitefile.py	96%	🟢
cognite_toolkit/_cdf_tk/resource_classes/containers.py	98%	🟢
cognite_toolkit/_cdf_tk/resource_classes/data_model.py	93%	🟢
cognite_toolkit/_cdf_tk/resource_classes/datapoint_subscription.py	97%	🟢
cognite_toolkit/_cdf_tk/resource_classes/dataset.py	91%	🟢
cognite_toolkit/_cdf_tk/resource_classes/event.py	94%	🟢
cognite_toolkit/_cdf_tk/resource_classes/extraction_pipeline.py	97%	🟢
cognite_toolkit/_cdf_tk/resource_classes/extraction_pipeline_config.py	89%	🟢
cognite_toolkit/_cdf_tk/resource_classes/filemetadata.py	96%	🟢
cognite_toolkit/_cdf_tk/resource_classes/function_schedule.py	92%	🟢
cognite_toolkit/_cdf_tk/resource_classes/functions.py	96%	🟢
cognite_toolkit/_cdf_tk/resource_classes/graphql_model.py	93%	🟢
cognite_toolkit/_cdf_tk/resource_classes/groups.py	97%	🟢
cognite_toolkit/_cdf_tk/resource_classes/hosted_extractor_destination.py	90%	🟢
cognite_toolkit/_cdf_tk/resource_classes/hosted_extractor_job.py	87%	🟢
cognite_toolkit/_cdf_tk/resource_classes/hosted_extractor_mapping.py	92%	🟢
cognite_toolkit/_cdf_tk/resource_classes/hosted_extractor_source.py	83%	🟢
cognite_toolkit/_cdf_tk/resource_classes/infield_cdm_location_config.py	98%	🟢
cognite_toolkit/_cdf_tk/resource_classes/infield_location_config.py	98%	🟢
cognite_toolkit/_cdf_tk/resource_classes/infield_v1.py	99%	🟢
cognite_toolkit/_cdf_tk/resource_classes/instance.py	93%	🟢
cognite_toolkit/_cdf_tk/resource_classes/labels.py	90%	🟢
cognite_toolkit/_cdf_tk/resource_classes/location.py	98%	🟢
cognite_toolkit/_cdf_tk/resource_classes/migration.py	92%	🟢
cognite_toolkit/_cdf_tk/resource_classes/raw_database_table.py	83%	🟢
cognite_toolkit/_cdf_tk/resource_classes/relationship.py	95%	🟢
cognite_toolkit/_cdf_tk/resource_classes/robotics/capability.py	92%	🟢
cognite_toolkit/_cdf_tk/resource_classes/robotics/data_postprocessing.py	91%	🟢
cognite_toolkit/_cdf_tk/resource_classes/robotics/frame.py	95%	🟢
cognite_toolkit/_cdf_tk/resource_classes/robotics/location.py	89%	🟢
cognite_toolkit/_cdf_tk/resource_classes/robotics/map.py	93%	🟢
cognite_toolkit/_cdf_tk/resource_classes/search_config.py	95%	🟢
cognite_toolkit/_cdf_tk/resource_classes/securitycategories.py	86%	🟢
cognite_toolkit/_cdf_tk/resource_classes/sequence.py	94%	🟢
cognite_toolkit/_cdf_tk/resource_classes/simulator_model.py	92%	🟢
cognite_toolkit/_cdf_tk/resource_classes/simulator_model_revision.py	90%	🟢
cognite_toolkit/_cdf_tk/resource_classes/simulator_routine.py	91%	🟢
cognite_toolkit/_cdf_tk/resource_classes/simulator_routine_revision.py	98%	🟢
cognite_toolkit/_cdf_tk/resource_classes/space.py	94%	🟢
cognite_toolkit/cdf_tk/resource_classes/streamlit.py	94%	🟢
cognite_toolkit/_cdf_tk/resource_classes/streams.py	92%	🟢
cognite_toolkit/_cdf_tk/resource_classes/threedmodels.py	89%	🟢
cognite_toolkit/_cdf_tk/resource_classes/timeseries.py	94%	🟢
cognite_toolkit/_cdf_tk/resource_classes/transformation_notification.py	88%	🟢
cognite_toolkit/_cdf_tk/resource_classes/transformation_schedule.py	89%	🟢
cognite_toolkit/_cdf_tk/resource_classes/transformations.py	92%	🟢
cognite_toolkit/_cdf_tk/resource_classes/views.py	98%	🟢
cognite_toolkit/_cdf_tk/resource_classes/workflow.py	89%	🟢
cognite_toolkit/_cdf_tk/resource_classes/workflow_trigger.py	93%	🟢
cognite_toolkit/_cdf_tk/resource_classes/workflow_version.py	99%	🟢
TOTAL	93%	🟢

updated for commit: e9354c8 by action🐍

codecov · 2026-02-16T14:58:48Z

Codecov Report

❌ Patch coverage is 67.06587% with 55 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.81%. Comparing base (6c84f6d) to head (e9354c8).
⚠️ Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
...gnite_toolkit/_cdf_tk/resource_classes/instance.py	60.00%	2 Missing ⚠️
...kit/_cdf_tk/resource_classes/raw_database_table.py	60.00%	2 Missing ⚠️
...gnite_toolkit/_cdf_tk/resource_classes/sequence.py	60.00%	2 Missing ⚠️
cognite_toolkit/_cdf_tk/resource_classes/agent.py	66.66%	1 Missing ⚠️
cognite_toolkit/_cdf_tk/resource_classes/asset.py	66.66%	1 Missing ⚠️
...te_toolkit/_cdf_tk/resource_classes/cognitefile.py	66.66%	1 Missing ⚠️
...ite_toolkit/_cdf_tk/resource_classes/containers.py	66.66%	1 Missing ⚠️
...ite_toolkit/_cdf_tk/resource_classes/data_model.py	66.66%	1 Missing ⚠️
..._cdf_tk/resource_classes/datapoint_subscription.py	66.66%	1 Missing ⚠️
...ognite_toolkit/_cdf_tk/resource_classes/dataset.py	66.66%	1 Missing ⚠️
... and 42 more

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2527      +/-   ##
==========================================
- Coverage   85.89%   85.81%   -0.09%     
==========================================
  Files         408      410       +2     
  Lines       34035    34222     +187     
==========================================
+ Hits        29235    29368     +133     
- Misses       4800     4854      +54

Files with missing lines	Coverage Δ
cognite_toolkit/_cdf_tk/resource_classes/base.py	`100.00% <100.00%> (ø)`
cognite_toolkit/_cdf_tk/resource_classes/agent.py	`93.75% <66.66%> (-6.25%)`	⬇️
cognite_toolkit/_cdf_tk/resource_classes/asset.py	`93.75% <66.66%> (-6.25%)`	⬇️
...te_toolkit/_cdf_tk/resource_classes/cognitefile.py	`96.42% <66.66%> (-3.58%)`	⬇️
...ite_toolkit/_cdf_tk/resource_classes/containers.py	`97.72% <66.66%> (-2.28%)`	⬇️
...ite_toolkit/_cdf_tk/resource_classes/data_model.py	`92.85% <66.66%> (-7.15%)`	⬇️
..._cdf_tk/resource_classes/datapoint_subscription.py	`96.87% <66.66%> (-3.13%)`	⬇️
...ognite_toolkit/_cdf_tk/resource_classes/dataset.py	`90.90% <66.66%> (-9.10%)`	⬇️
cognite_toolkit/_cdf_tk/resource_classes/event.py	`93.75% <66.66%> (-6.25%)`	⬇️
...it/_cdf_tk/resource_classes/extraction_pipeline.py	`96.55% <66.66%> (-3.45%)`	⬇️
... and 43 more

... and 8 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

doctrino · 2026-02-17T06:45:46Z

/gemini review

gemini-code-assist

Code Review

This pull request introduces a consistent way to get an identifier for each YAML resource class by adding an abstract as_id method to the ToolkitResource base class. This is a great refactoring that improves the structure and maintainability of the codebase. The changes are implemented consistently across all relevant resource classes. The code is clean, correct, and follows the repository's style guide. I have no further comments.

doctrino marked this pull request as ready for review February 16, 2026 14:54

doctrino requested review from a team as code owners February 16, 2026 14:54

gemini-code-assist bot reviewed Feb 16, 2026

View reviewed changes

cognite_toolkit/_cdf_tk/resource_classes/base.py Outdated Show resolved Hide resolved

doctrino added 3 commits February 17, 2026 07:45

reactorÃ set id

f7c0f3e

feat: implementÃ

cec470e

fix:

e9354c8

doctrino force-pushed the as-id branch from 56c644b to e9354c8 Compare February 17, 2026 06:45

doctrino enabled auto-merge (squash) February 17, 2026 06:46

gemini-code-assist bot reviewed Feb 17, 2026

View reviewed changes

ronpal approved these changes Feb 17, 2026

View reviewed changes

doctrino merged commit 81b84de into main Feb 17, 2026
15 checks passed

doctrino deleted the as-id branch February 17, 2026 07:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CDF-27110] 🧱As id method for YAML classes#2527

[CDF-27110] 🧱As id method for YAML classes#2527
doctrino merged 3 commits intomainfrom
as-id

doctrino commented Feb 16, 2026 •

edited

Loading

Uh oh!

gemini-code-assist bot commented Feb 16, 2026

Uh oh!

doctrino commented Feb 16, 2026

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

Uh oh!

github-actions bot commented Feb 16, 2026 •

edited

Loading

Uh oh!

codecov bot commented Feb 16, 2026 •

edited

Loading

Uh oh!

doctrino commented Feb 17, 2026

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

doctrino commented Feb 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Bump

Uh oh!

gemini-code-assist bot commented Feb 16, 2026

Uh oh!

doctrino commented Feb 16, 2026

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

github-actions bot commented Feb 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

☂️ Python Coverage

Overall Coverage

New Files

Modified Files

Uh oh!

codecov bot commented Feb 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

doctrino commented Feb 17, 2026

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

doctrino commented Feb 16, 2026 •

edited

Loading

github-actions bot commented Feb 16, 2026 •

edited

Loading

codecov bot commented Feb 16, 2026 •

edited

Loading