add hydraulic resistance and heat transfer coefficient, and correspon…#208
add hydraulic resistance and heat transfer coefficient, and correspon…#208henmcn wants to merge 7 commits into
Conversation
evertoncolling
left a comment
evertoncolling
left a comment
There was a problem hiding this comment.
Make sure the values are consistent within a given unit and are accurately representing the values from the source when a canonical source is referenced.
| "sourceReference": null | ||
| }, | ||
| { | ||
| "externalId": "hydraulic_resistance:pa-per-m3s", |
There was a problem hiding this comment.
This entry is completely messed up. In the name and description, it refer to linear hydraulic resistance, but in the symbol and aliases it refers to quadratic hydraulic resistance.
The linear version has an entry in qudt and should be adopted as the canonical reference: https://qudt.org/vocab/unit/PA-SEC-PER-M3
There was a problem hiding this comment.
The quantity here would be "Pressure in Relation to Volume Flow Rate" (or "Pressure in Relation to Squared Volume Flow Rate" if the quadratic variation is the one of interest).
| { | ||
| "externalId": "heat_transfer_coefficient:watt-per-m2k", | ||
| "name": "WATT-PER-M2K", | ||
| "quantity": "Heat Transfer Coefficient", |
There was a problem hiding this comment.
When following qudt, we should adopt the same values for the qudt entries. For example, the quantity here should match the qudt quantityKind "Coefficient of Heat Transfer".
There was a problem hiding this comment.
I didn’t check the other fields this time, as I see it’s not matching at all to the source.
| "source": "https://qudt.org/vocab/unit/W-PER-M2-K", | ||
| "sourceReference": null |
There was a problem hiding this comment.
I recommend looking at existing entries and follow the existing patterns in the catalog.
| "source": "https://qudt.org/vocab/unit/W-PER-M2-K", | |
| "sourceReference": null | |
| "source": "qudt.org", | |
| "sourceReference": "https://qudt.org/vocab/unit/W-PER-M2-K" |
| { | ||
| "externalId": "heat_transfer_coefficient_gradient:watt-per-m2k-per-day", | ||
| "name": "WATT-PER-M2K-PER-DAY", | ||
| "quantity": "Heat Transfer Coefficient Gradient", |
There was a problem hiding this comment.
This quantity should be something like: "Coefficient of Heat Transfer Per Time", as gradients in this catalog are used for spatial gradients, not temporal ones, and that would introduce ambiguity.
| { | ||
| "externalId": "hydraulic_resistance_gradient:pa-per-m3s-per-day", | ||
| "name": "PA-PER-M3S-PER-DAY", | ||
| "quantity": "Hydraulic Resistance Gradient", |
There was a problem hiding this comment.
This one would be: "Pressure in Relation to Volume Flow Rate Per Time"
2 participants
…ding gradients