Skip to content

Add Pound-per-Foot#209

Open
Marwen94 wants to merge 2 commits into
cognitedata:mainfrom
Marwen94:feat/AddPoundPerFoot
Open

Add Pound-per-Foot#209
Marwen94 wants to merge 2 commits into
cognitedata:mainfrom
Marwen94:feat/AddPoundPerFoot

Conversation

@Marwen94

Copy link
Copy Markdown
Contributor

Add Pound-per-Foot ad linear density unit
specs: https://qudt.org/vocab/unit/LB-PER-FT

@Marwen94 Marwen94 requested a review from a team as a code owner June 16, 2026 07:37
@Marwen94 Marwen94 changed the title feat: Add Pound-per-Foot Add Pound-per-Foot Jun 16, 2026

@evertoncolling evertoncolling left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly ok, just some small changes needed, due to drift from the source reference.

Also, since you are adding an Imperial linear-density unit, we should add it to the Imperial unit system in

"name": "Imperial",

Comment thread versions/v1/units.json
"externalId": "linear_density:lb-per-ft",
"name": "LB-PER-FT",
"quantity": "Linear Density",
"longName": "Pound per Foot",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"longName": "Pound per Foot",
"longName": "Pound Mass per Foot",

Comment thread versions/v1/units.json
"lb-per-ft",
"LB/FT"
],
"symbol": "lb/ft",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"symbol": "lb/ft",
"symbol": "lbm/ft",

Comment thread versions/v1/units.json
],
"symbol": "lb/ft",
"conversion": {
"multiplier": 1.48816,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We try to keep the precision from the source reference up to 17 significant digits following the IEEE 754 double-precision round-trip limit.

Suggested change
"multiplier": 1.48816,
"multiplier": 1.4881639435695537,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants