[fix][fn]Support for pulsar.service.url in the Local Run Mode for Debezium IO connectors#7
Open
sandeep-mst wants to merge 3 commits intomasterfrom
Open
[fix][fn]Support for pulsar.service.url in the Local Run Mode for Debezium IO connectors#7sandeep-mst wants to merge 3 commits intomasterfrom
sandeep-mst wants to merge 3 commits intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes 21276 of apache/pulsar
Motivation
Local run mode which is used for debugging functions doesn't support pulsar.service.url from Debezium IO connectors. It is always picking up the default value of "pulsar://localhost:6650".
Modifications
Modified so that it picks the broker url specified in "pulsar.service.url" from source or sink config if specified. The priority will be "--brokerServiceUrl" if specified and if not, it will pick up pulsar.service.url from source or sink config.
Verifying this change
(Please pick either of the following options)
This change is already covered by existing tests, such as (please describe tests).
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: