remove more of the mypy ignore list

[frrad]

This removes the last of the "real" exceptions from pyproject.toml, adding type: ignore as needed.

[frrad]

this is unrelated, just saw it as I was reading the code.

[frrad]

the SkipTest decorators below failed to type check. I was deciding between this and just unilateral skip with @unittest.skip. Happy to go the other way if you want.

[pchtsp]

I don't really understand the difference between unittest.SkipTest and unittest.skip. Maybe @torressa knows ?

[torressa]

I think they can be changed to unittest.skip. Not sure about the SkipTest decorator is working as expected anymore. In any case, we really want to skip these as they are only relevant when using a specific license (single use).

[pchtsp]

Is there a way to check for the single use license inside the is_single_use_license function and return true/false?

[torressa]

With gurobipy one could do:

def is_single_use_license() -> bool:
    try:
        with gp.Env() as env1:
            with gp.Env() as env2:
                pass
    except gp.GurobiError as ge:
        if ge.errno == gp.GRB.Error.NO_LICENSE:
            print("single use license")
            print(f"Error code {ge.errno}: {ge}")
            return True
    return False

This is enough to trigger an error in a single-use case.

[frrad]

mypy complains about these type hints since these variables are already defined.

[frrad]

I have put in the implementation supplied by @torressa. Thanks!

On my machine these tests are still skipped. If you have a single-use license environment to play with it might be good to verify that they are run and pass.

pytest -rs pulp/tests/test_gurobipy_env.py
================================================== test session starts ===================================================
platform linux -- Python 3.10.14, pytest-8.3.5, pluggy-1.5.0
rootdir: /home/frederick/Projects/pulp
configfile: pyproject.toml
plugins: darkgraylib-1.2.1
collected 7 items                                                                                                        

pulp/tests/test_gurobipy_env.py s.ss...                                                                            [100%]

================================================ short test summary info =================================================
SKIPPED [1] pulp/tests/test_gurobipy_env.py:83: this test is only expected to pass with a single-use license
SKIPPED [1] pulp/tests/test_gurobipy_env.py:56: this test is only expected to pass with a single-use license
SKIPPED [1] pulp/tests/test_gurobipy_env.py:123: this test is only expected to pass with a single-use license
============================================== 4 passed, 3 skipped in 0.23s ==============================================

[pchtsp]

it seems to still fail with the current changes, @frrad could you take a look? thanks!

[frrad]

It was working! I wonder what changed 🤔 will take a look.

[frrad]

Fixed! Looks like some minor conflict with #831