-
Notifications
You must be signed in to change notification settings - Fork 115
fix: Remove the BaseAccount inheritance from EvmServerAccount #581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Heimdall Review Status
|
2ebd61f to
b878f34
Compare
0xRAG
reviewed
Jan 29, 2026
0xRAG
previously approved these changes
Jan 29, 2026
Contributor
0xRAG
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM, just had one question!
1696d52 to
70baa5d
Compare
0xRAG
previously approved these changes
Jan 29, 2026
sammccord
previously approved these changes
Jan 29, 2026
aa4d3f9 to
42d5cc1
Compare
sammccord
approved these changes
Jan 29, 2026
0xRAG
approved these changes
Jan 29, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removed the BaseAccount inheritance from EvmServerAccount.
Closes this issue.
Changes Made
1. Removed the problematic inheritance
class EvmServerAccount(BaseAccount, BaseModel)→class EvmServerAccount(BaseModel)BaseAccountBaseAccountas aTYPE_CHECKING-only import for type hints2. Added comprehensive documentation
The new docstring explains:
BaseAccount(async vs sync incompatibility)BaseAccountcompatibility (useEvmLocalAccountwrapper)3. Fixed type annotations
from __future__ import annotationsfor forward referencestransfer()method signature to use proper type hints withBaseAccountWhy This Works
1. No Breaking Changes in Practice
The code that would break (passing
EvmServerAccountwhereBaseAccountis expected) was already broken because the methods return coroutines instead of results.2. Existing Tests Pass
All tests pass because:
EvmLocalAccount(notEvmServerAccount) when aBaseAccountis neededEvmServerAccountwithawaitcontinues to work unchanged3. Clean Architecture
EvmServerAccount= Pure async API (network-based operations)EvmLocalAccount= Sync wrapper for eth_account compatibilityThe Full Picture
This fix resolves the Liskov Substitution Principle violation mentioned in the GitHub issue. The class was claiming to be a
BaseAccountbut couldn't actually fulfill that contract because:BaseAccountmethods are synchronousThe solution aligns with the codebase's existing pattern
EvmLocalAccountalready existed as the proper sync wrapper, so removing the false inheritance makes the architecture honest and clear.Tests
Checklist
A couple of things to include in your PR for completeness: