fix: prevent duplicated release notes from matrix job re-generation - #10
Merged
Conversation
The release job runs as a 4-way RID matrix, and each leg called action-gh-release with generate_release_notes: true, causing the generated notes to be appended to the same release once per leg. Split out a separate finalize-release job that runs once after all platform artifacts are uploaded to generate the notes and set the title.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
generate_release_notes: true, so the generated notes got appended to the same release once per leg (4 times total).finalize-releasejob that runs once after all platform artifacts are uploaded, to generate the release notes and set the title.Test plan
v0.0.0-test1) to trigger the release workflow and confirm the Changes section appears only once