refactor: reorder members and add XML docs across Core/Cli - #8
Merged
Conversation
Alphabetizes usings and sorts members within touched types, adds XML doc comments, and fixes three behavioral regressions surfaced by review: SessionFileCache.GetRows now re-validates file mtime before returning cached rows, StatsCacheBuilder prunes stale session-file cache entries again, and DataService's stats-cache expiration uses UTC instead of local time to avoid DST drift.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AIUsageMonitor.CoreandAIUsageMonitor.Cli, adding XML doc comments./code-review:SessionFileCache.GetRowsre-validates the file's last-write time before returning cached rows instead of trusting the cache unconditionally.StatsCacheBuilder.Buildprunes stale entries fromSessionFileCacheagain (was dropped along with the removedPrunemethod), as a safety net for missedFileSystemWatcherdeletions.DataService.GetStatsCachecomputes the cache expiry usingDateTimeOffset.UtcNowinstead of local time, avoiding DST-related drift.Test plan
dotnet build AIUsageMonitor.slnxdotnet test AIUsageMonitor.slnx(31 passed)